linux-kernel - Re: [PATCH] bpf: fix order of args in call to bpf_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <363ad8d1-a2d2-4fca-b66a-3d838eb5def9@intel.com>
Date: Wed, 12 Jun 2024 08:20:42 +0300
From: Péter Ujfalusi <peter.ujfalusi@...el.com>
To: <patchwork-bot+netdevbpf@...nel.org>, Mohammad Shehar Yaar Tausif
	<sheharyaar48@...il.com>
CC: <martin.lau@...ux.dev>, <ast@...nel.org>, <daniel@...earbox.net>,
	<andrii@...nel.org>, <eddyz87@...il.com>, <song@...nel.org>,
	<yonghong.song@...ux.dev>, <john.fastabend@...il.com>, <kpsingh@...nel.org>,
	<sdf@...gle.com>, <haoluo@...gle.com>, <jolsa@...nel.org>,
	<bpf@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH] bpf: fix order of args in call to bpf_map_kvcalloc

Hi,

On 17/05/2024 06:10, patchwork-bot+netdevbpf@...nel.org wrote:
> Hello:
> 
> This patch was applied to bpf/bpf-next.git (master)

Can you send this patch for the current 6.10 cycle as a fix as well?

HEAD:
2ef5971ff345 Merge tag 'vfs-6.10-rc4.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs

head -n 6 Makefile 
# SPDX-License-Identifier: GPL-2.0
VERSION = 6
PATCHLEVEL = 10
SUBLEVEL = 0
EXTRAVERSION = -rc3
NAME = Baby Opossum Posse

gcc --version
gcc (GCC) 14.1.1 20240522

kernel/bpf/bpf_local_storage.c: In function ‘bpf_local_storage_map_alloc’:
kernel/bpf/bpf_local_storage.c:785:60: error: ‘kvmalloc_array_node_noprof’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
  785 |         smap->buckets = bpf_map_kvcalloc(&smap->map, sizeof(*smap->buckets),

Thank you,
Péter

> by Andrii Nakryiko <andrii@...nel.org>:
> 
> On Thu, 16 May 2024 12:54:11 +0530 you wrote:
>> The original function call passed size of smap->bucket before the number of
>> buckets which raises the error 'calloc-transposed-args' on compilation.
>>
>> Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@...il.com>
>> ---
>>  kernel/bpf/bpf_local_storage.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Here is the summary with links:
>   - bpf: fix order of args in call to bpf_map_kvcalloc
>     https://git.kernel.org/bpf/bpf-next/c/71ed6c266348
> 
> You are awesome, thank you!
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.