linux-kernel - Re: [PATCH 2/3] pwm: cros-ec: Simplify device tree xlation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zmk_zmlyulWRejc7@google.com>
Date: Wed, 12 Jun 2024 06:27:26 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Uwe Kleine-König <ukleinek@...libre.com>
Cc: Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>,
	linux-pwm@...r.kernel.org, chrome-platform@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] pwm: cros-ec: Simplify device tree xlation

On Fri, Jun 07, 2024 at 10:44:16AM +0200, Uwe Kleine-König wrote:
> The cros-ec device tree binding only uses #pwm-cells = <1>, and so there
> is no period provided in the device tree. Up to now this was handled by
> hardcoding the period to the only supported value in the custom xlate
> callback. Apart from that, the default xlate callback (i.e.
> of_pwm_xlate_with_flags()) handles this just fine (and better, e.g. by
> checking args->args_count >= 1 before accessing args->args[0]).
> 
> To simplify make use of of_pwm_xlate_with_flags(), drop the custom
> callback and provide the default period in .probe() already.
> 
> Apart from simplifying the driver this also drops the last non-core user
> of pwm_request_from_chip() and so makes further simplifications
> possible.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>

Reviewed-by: Tzung-Bi Shih <tzungbi@...nel.org>