linux-kernel - Re: [PATCH unstable] mm: rmap: abstract updating per-node and per-memcg stats fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03f1f5a5-e2eb-4dec-9c03-5d00243ee485@redhat.com>
Date: Wed, 12 Jun 2024 09:23:50 +0200
From: David Hildenbrand <david@...hat.com>
To: Hugh Dickins <hughd@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>
Cc: Yosry Ahmed <yosryahmed@...gle.com>, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org
Subject: Re: [PATCH unstable] mm: rmap: abstract updating per-node and
 per-memcg stats fix

On 12.06.24 07:10, Hugh Dickins wrote:
> /proc/meminfo is showing ridiculously large numbers on some lines:
> __folio_remove_rmap()'s __folio_mod_stat() should be subtracting!
> 
> Signed-off-by: Hugh Dickins <hughd@...gle.com>
> ---
> A fix for folding into mm-unstable, not needed for 6.10-rc.
> 
>   mm/rmap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1567,7 +1567,7 @@ static __always_inline void __folio_remove_rmap(struct folio *folio,
>   		    list_empty(&folio->_deferred_list))
>   			deferred_split_folio(folio);
>   	}
> -	__folio_mod_stat(folio, nr, nr_pmdmapped);
> +	__folio_mod_stat(folio, -nr, -nr_pmdmapped);
>   
>   	/*
>   	 * It would be tidy to reset folio_test_anon mapping when fully

Missed that detail, thanks!

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb