linux-kernel - Re: [PATCH] crypto: starfive - Align rsa input data to 32-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 12 Jun 2024 15:46:54 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: JiaJie Ho <jiajie.ho@...rfivetech.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: starfive - Align rsa input data to 32-bit

On Wed, Jun 12, 2024 at 02:58:18AM +0000, JiaJie Ho wrote:
>
> Can I fix the buffer length of the pre-allocated buffer to 256 bytes instead of
> the current variable length buffer? 
> 
> -        u8 rsa_data[] __aligned(sizeof(u32));
> +       u8 rsa_data[STARFIVE_RSA_MAX_KEYSZ];
> 
> That's the maximum length supported by the hardware and 
> most applications now use rsa2048 and above.

I think that's fine.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt