linux-kernel - Re: [PATCH] soc: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 12 Jun 2024 10:12:27 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: neil.armstrong@...aro.org, Jeff Johnson <quic_jjohnson@...cinc.com>,
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Linus Walleij <linusw@...nel.org>,
 Imre Kaloz <kaloz@...nwrt.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Arnd Bergmann <arnd@...db.de>
Cc: linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org,
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 linux-mediatek@...ts.infradead.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] soc: add missing MODULE_DESCRIPTION() macros

Il 12/06/24 09:58, Neil Armstrong ha scritto:
> On 12/06/2024 07:50, Jeff Johnson wrote:
>> With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/imx/soc-imx8m.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-qmgr.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-npe.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in 
>> drivers/soc/mediatek/mtk-cmdq-helper.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in 
>> drivers/soc/amlogic/meson-clk-measure.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>> ---
>> This is the last of the issues that I see in the soc directory
>> ---
>>   drivers/soc/amlogic/meson-clk-measure.c | 1 +
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org> # for 
> amlogic/meson-clk-measure.c
> 
>>   drivers/soc/imx/soc-imx8m.c             | 1 +
>>   drivers/soc/ixp4xx/ixp4xx-npe.c         | 1 +
>>   drivers/soc/ixp4xx/ixp4xx-qmgr.c        | 1 +
>>   drivers/soc/mediatek/mtk-cmdq-helper.c  | 1 +
>>   5 files changed, 5 insertions(+)
>>

MediaTek:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

...but I'm not sure how we should apply this? :-)

Either Arnd takes it directly, or you split it per-soc... and I don't have any
preference anyway.

(P.S.: Added Arnd to the loop)

Cheers,
Angelo

>> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c 
>> b/drivers/soc/mediatek/mtk-cmdq-helper.c
>> index 046522664dc1..dd70d4d2bed7 100644
>> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
>> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
>> @@ -526,4 +526,5 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
>>   }
>>   EXPORT_SYMBOL(cmdq_pkt_finalize);
>> +MODULE_DESCRIPTION("MediaTek Command Queue (CMDQ) driver");
>>   MODULE_LICENSE("GPL v2");
>>
>> ---
>> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
>> change-id: 20240611-md-drivers-soc-1780b1939627
>>
>