[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3b24ef4a-996b-4a8b-89f3-385872573039@suse.de>
Date: Wed, 12 Jun 2024 10:33:42 +0200
From: Hannes Reinecke <hare@...e.de>
To: Wenchao Hao <haowenchao22@...il.com>,
"James E . J . Bottomley" <James.Bottomley@...senPartnership.com>,
"Martin K . Petersen" <martin.petersen@...cle.com>,
linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/3] scsi: core: Add new helper to iterate all devices
of host
On 6/5/24 11:17, Wenchao Hao wrote:
> shost_for_each_device() would skip devices which is in SDEV_CANCEL or
> SDEV_DEL state, for some scenarios, we donot want to skip these devices,
> so add a new macro shost_for_each_device_include_deleted() to handle it.
>
> Following changes are introduced:
>
> 1. Rework scsi_device_get(), add new helper __scsi_device_get() which
> determine if skip deleted scsi_device by parameter "skip_deleted".
> 2. Add new parameter "skip_deleted" to __scsi_iterate_devices() which
> is used when calling __scsi_device_get()
> 3. Update shost_for_each_device() to call __scsi_iterate_devices() with
> "skip_deleted" true
> 4. Add new macro shost_for_each_device_include_deleted() which call
> __scsi_iterate_devices() with "skip_deleted" false
>
> Signed-off-by: Wenchao Hao <haowenchao22@...il.com>
> ---
> drivers/scsi/scsi.c | 46 ++++++++++++++++++++++++++------------
> include/scsi/scsi_device.h | 25 ++++++++++++++++++---
> 2 files changed, 54 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
> index 3e0c0381277a..5913de543d93 100644
> --- a/drivers/scsi/scsi.c
> +++ b/drivers/scsi/scsi.c
> @@ -735,20 +735,18 @@ int scsi_cdl_enable(struct scsi_device *sdev, bool enable)
> return 0;
> }
>
> -/**
> - * scsi_device_get - get an additional reference to a scsi_device
> +/*
> + * __scsi_device_get - get an additional reference to a scsi_device
> * @sdev: device to get a reference to
> - *
> - * Description: Gets a reference to the scsi_device and increments the use count
> - * of the underlying LLDD module. You must hold host_lock of the
> - * parent Scsi_Host or already have a reference when calling this.
> - *
> - * This will fail if a device is deleted or cancelled, or when the LLD module
> - * is in the process of being unloaded.
> + * @skip_deleted: when true, would return failed if device is deleted
> */
> -int scsi_device_get(struct scsi_device *sdev)
> +static int __scsi_device_get(struct scsi_device *sdev, bool skip_deleted)
> {
> - if (sdev->sdev_state == SDEV_DEL || sdev->sdev_state == SDEV_CANCEL)
> + /*
> + * if skip_deleted is true and device is in removing, return failed
> + */
> + if (skip_deleted &&
> + (sdev->sdev_state == SDEV_DEL || sdev->sdev_state == SDEV_CANCEL))
> goto fail;
Nack.
SDEV_DEL means the device is about to be deleted, so we _must not_
access it at all.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@...e.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
Powered by blists - more mailing lists