linux-kernel - Re: [PATCH] mm/hugetlb: Guard dequeue_hugetlb_folio_nodemask against NUMA_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5237BBD3-818B-4E06-A56A-80BE705EB024@linux.dev>
Date: Wed, 12 Jun 2024 16:53:34 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Oscar Salvador <osalvador@...e.de>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 LKML <linux-kernel@...r.kernel.org>,
 Linux-MM <linux-mm@...ck.org>,
 Vivek Kasireddy <vivek.kasireddy@...el.com>,
 syzbot+569ed13f4054f271087b@...kaller.appspotmail.com
Subject: Re: [PATCH] mm/hugetlb: Guard dequeue_hugetlb_folio_nodemask against
 NUMA_NO_NODE uses



> On Jun 12, 2024, at 16:29, Oscar Salvador <osalvador@...e.de> wrote:
> 
> dequeue_hugetlb_folio_nodemask() expects a preferred node where to get the
> hugetlb page from.
> It does not expect, though, users to pass NUMA_NO_NODE, otherwise we will
> get trash when trying to get the zonelist from that node.
> All current users are careful enough to not pass NUMA_NO_NODE, but
> it opens the door for new users to get this wrong since it is not
> documented [0].
> Guard against this by getting the local nid if NUMA_NO_NODE was passed.
> 
> [0] https://lore.kernel.org/linux-mm/0000000000004f12bb061a9acf07@google.com/
> 
> Closes: https://lore.kernel.org/linux-mm/0000000000004f12bb061a9acf07@google.com/
> Reported-and-tested-by: syzbot+569ed13f4054f271087b@...kaller.appspotmail.com
> Signed-off-by: Oscar Salvador <osalvador@...e.de>

Reviewed-by: Muchun Song <muchun.song@...ux.dev>

Thanks.