linux-kernel - Re: [PATCH 2/2] dt-bindings: cache: qcom,llcc: Fix QDU1000 description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZmlohTUi6Ppl4k6f@hu-mojha-hyd.qualcomm.com>
Date: Wed, 12 Jun 2024 14:51:09 +0530
From: Mukesh Ojha <quic_mojha@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Komal Bajaj <quic_kbajaj@...cinc.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: cache: qcom,llcc: Fix QDU1000
 description

On Wed, Jun 12, 2024 at 09:58:50AM +0200, Krzysztof Kozlowski wrote:
> On 12/06/2024 08:27, Komal Bajaj wrote:
> > QDU1000 DTSI comes with one LLCC0-7 base addresses. Updating
> > dt-bindings accordingly.
> > 
> > Fixes: f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")
> 
> You are basically reverting without saying this is a revert and without
> explanation.
> 
> What's happening with QDU1000? Why it is such a mess that DTS was
> totally not matching bindings drivers and now suddenly we need to revert
> commits?

I think, this happened because of the refactoring happened in LLCC driver
and at the same time QDU1000 device tree change picked while other SoCs
change was made like 

e.g
https://lore.kernel.org/r/20230314080443.64635-11-manivannan.sadhasivam@linaro.org
https://lore.kernel.org/r/20230517-topic-kailua-llcc-v1-2-d57bd860c43e@linaro.org


However, this change missed for QDU1000, later f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")
happened and now realized the driver does not work anymore with current
binding and hence fixing was required.

-Mukesh