[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6304a5a2-1ca0-4e6c-8c0a-e7b320f64c7d@arm.com>
Date: Wed, 12 Jun 2024 10:28:58 +0100
From: Steven Price <steven.price@....com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
boris.brezillon@...labora.com
Cc: maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, matthias.bgg@...il.com,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, Chen-Yu Tsai <wenst@...omium.org>
Subject: Re: [PATCH v3 2/2] drm/panfrost: Add support for Mali on the MT8188
SoC
On 11/06/2024 09:56, AngeloGioacchino Del Regno wrote:
> MediaTek MT8188 has a Mali-G57 MC3 (Valhall-JM): add a new
> compatible and platform data using the same supplies and the
> same power domain lists as MT8183 (one regulator, three power
> domains).
>
> Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Reviewed-by: Steven Price <steven.price@....com>
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index ef9f6c0716d5..b43557b10ae3 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -777,6 +777,15 @@ static const struct panfrost_compatible mediatek_mt8186_data = {
> .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF),
> };
>
> +/* MT8188 uses the same power domains and power supplies as MT8183 */
> +static const struct panfrost_compatible mediatek_mt8188_data = {
> + .num_supplies = ARRAY_SIZE(mediatek_mt8183_b_supplies) - 1,
> + .supply_names = mediatek_mt8183_b_supplies,
> + .num_pm_domains = ARRAY_SIZE(mediatek_mt8183_pm_domains),
> + .pm_domain_names = mediatek_mt8183_pm_domains,
> + .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF),
> +};
> +
> static const char * const mediatek_mt8192_supplies[] = { "mali", NULL };
> static const char * const mediatek_mt8192_pm_domains[] = { "core0", "core1", "core2",
> "core3", "core4" };
> @@ -808,6 +817,7 @@ static const struct of_device_id dt_match[] = {
> { .compatible = "mediatek,mt8183-mali", .data = &mediatek_mt8183_data },
> { .compatible = "mediatek,mt8183b-mali", .data = &mediatek_mt8183_b_data },
> { .compatible = "mediatek,mt8186-mali", .data = &mediatek_mt8186_data },
> + { .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data },
> { .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data },
> {}
> };
Powered by blists - more mailing lists