[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2024061206-unleveled-seduce-9861@gregkh>
Date: Wed, 12 Jun 2024 12:00:40 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Dan Williams <dan.j.williams@...el.com>
Cc: nvdimm@...ts.linux.dev, linux-kernel@...r.kernel.org,
Vishal Verma <vishal.l.verma@...el.com>,
Dave Jiang <dave.jiang@...el.com>, Ira Weiny <ira.weiny@...el.com>
Subject: Re: [PATCH] nvdimm: make nd_class constant
On Mon, Jun 10, 2024 at 10:44:42AM -0700, Dan Williams wrote:
> Greg Kroah-Hartman wrote:
> > Now that the driver core allows for struct class to be in read-only
> > memory, we should make all 'class' structures declared at build time
> > placing them into read-only memory, instead of having to be dynamically
> > allocated at runtime.
>
> Change looks good to me,
>
> Reviewed-by: Dan Williams <dan.j.williams@...el.com>
>
> ...changelog grammar tripped me up though, how about:
>
> "Now that the driver core allows for struct class to be in read-only
> memory, it is possible to make all 'class' structures be declared at
> build time. Move the class to a 'static const' declaration and register
> it rather than dynamically create it."
That works too, want me to resubmit with this, or can I update it when I
commit it to my tree?
thanks,
greg "the changelog is the hardest part" k-h
Powered by blists - more mailing lists