[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240612105232.400361-1-abdulrasaqolawani@gmail.com>
Date: Wed, 12 Jun 2024 06:51:58 -0400
From: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>
To: sakari.ailus@...ux.intel.com,
dave.stevenson@...pberrypi.com,
jacopo@...ndi.org,
mchehab@...nel.org
Cc: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>,
linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org,
skhan@...uxfoundation.org,
javier.carrasco.cruz@...il.com,
julia.lawall@...ia.fr
Subject: [PATCH v2] media: i2c: ov5647: replacing of_node_put with __free(device_node)
Replace instance of of_node_put with __free(device_node)
to protect against any memory leaks due to future changes
in control flow.
Signed-off-by: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>
---
drivers/media/i2c/ov5647.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
index 7e1ecdf2485f..0fb4d7bff9d1 100644
--- a/drivers/media/i2c/ov5647.c
+++ b/drivers/media/i2c/ov5647.c
@@ -1360,24 +1360,21 @@ static int ov5647_parse_dt(struct ov5647 *sensor, struct device_node *np)
struct v4l2_fwnode_endpoint bus_cfg = {
.bus_type = V4L2_MBUS_CSI2_DPHY,
};
- struct device_node *ep;
+ struct device_node *ep __free(device_node) =
+ of_graph_get_endpoint_by_regs(np, 0, -1);
int ret;
- ep = of_graph_get_endpoint_by_regs(np, 0, -1);
if (!ep)
return -EINVAL;
ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &bus_cfg);
if (ret)
- goto out;
+ return ret;
sensor->clock_ncont = bus_cfg.bus.mipi_csi2.flags &
V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK;
-out:
- of_node_put(ep);
-
- return ret;
+ return 0;
}
static int ov5647_probe(struct i2c_client *client)
--
2.43.0
Powered by blists - more mailing lists