linux-kernel - Re: [PATCH] regulator: bd71815: fix ramp values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e9f27dc-80fb-4f0d-a29d-b418a7e96042@gmail.com>
Date: Wed, 12 Jun 2024 14:47:40 +0300
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Kalle Niemi <kaleposti@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: bd71815: fix ramp values

Hi Kalle,

Thanks for finding and fixing this!

On 6/12/24 14:42, Kalle Niemi wrote:
> Ramp values are inverted. This caused wrong values written to register
> when ramp values were defined in device tree.
> 
> Invert values in table to fix this.
> 
> Signed-off-by: Kalle Niemi <kaleposti@...il.com>

Reviewed-by: Matti Vaittinen <mazziesaccount@...il.com>

> Fixes: 1aad39001e85 ("regulator: Support ROHM BD71815 regulators")
> ---
>   drivers/regulator/bd71815-regulator.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/bd71815-regulator.c b/drivers/regulator/bd71815-regulator.c
> index 26192d55a685..79fbb45297f6 100644
> --- a/drivers/regulator/bd71815-regulator.c
> +++ b/drivers/regulator/bd71815-regulator.c
> @@ -256,7 +256,7 @@ static int buck12_set_hw_dvs_levels(struct device_node *np,
>    * 10: 2.50mV/usec	10mV 4uS
>    * 11: 1.25mV/usec	10mV 8uS
>    */
> -static const unsigned int bd7181x_ramp_table[] = { 1250, 2500, 5000, 10000 };
> +static const unsigned int bd7181x_ramp_table[] = { 10000, 5000, 2500, 1250 };
>   
>   static int bd7181x_led_set_current_limit(struct regulator_dev *rdev,
>   					int min_uA, int max_uA)
> 
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~