linux-kernel - Re: [PATCH] dt-bindings: wlf,wm8782: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 12 Jun 2024 17:29:34 +0530
From: Animesh Agarwal <animeshagarwal28@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: Daniel Baluta <daniel.baluta@....com>, Liam Girdwood <lgirdwood@...il.com>, 
	Mark Brown <broonie@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, patches@...nsource.cirrus.com, 
	linux-sound@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: wlf,wm8782: Convert to dtschema

On Wed, Jun 12, 2024 at 1:30 AM Rob Herring <robh@...nel.org> wrote:
>
> On Tue, Jun 11, 2024 at 06:14:00PM +0530, Animesh Agarwal wrote:
> > Convert the WM8782 audio codec bindings to DT schema.
>
> Missing "ASoC" on the subject. Mark may not see it.
>
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
> > Cc: Daniel Baluta <daniel.baluta@....com>
> > ---
> >  .../devicetree/bindings/sound/wlf,wm8782.yaml | 47 +++++++++++++++++++
> >  .../devicetree/bindings/sound/wm8782.txt      | 24 ----------
> >  2 files changed, 47 insertions(+), 24 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8782.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/sound/wm8782.txt
>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
>
>
> This is yet another binding with no in tree DTS user. That's fine, but
> not what I would prioritize converting. There are several ways I would
> prioritize what to work on.

I'll resend this patch adding "ASOC" in the subject, thanks for the
advice I'll not prioritize bindings that do not have their DTS in the
tree.

> - There's a list maintained in CI of number of occurrences of
> undocumented (by schema) compatibles[1]. Start at the top (most
> occurrences).
> - Pick a platform (or family of platform) and get the warnings down to
> 0 or close. There's a grouping of warnings and undocumented
> compatibles by platform family at the same link. Pick something that's
> widely used like RPi or RK3399.
> - Prioritize newer platforms over older (arm64 rather than
> arm32(though there's still new arm32 stuff)).
> - Fix warnings treewide from common schemas (i.e. from dtschema).
> That's not conversions, but related.

Thanks for the tips. I'll work accordingly.

Animesh