linux-kernel - Re: [PATCH v6 1/1] nvme-multipath: implement "queue-depth" iopolicy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <868707d5-bbe5-4f10-8395-333caa867a82@redhat.com>
Date: Wed, 12 Jun 2024 09:07:33 -0400
From: John Meneghini <jmeneghi@...hat.com>
To: Chaitanya Kulkarni <chaitanyak@...dia.com>,
 "kbusch@...nel.org" <kbusch@...nel.org>, "hch@....de" <hch@....de>,
 "sagi@...mberg.me" <sagi@...mberg.me>, "emilne@...hat.com"
 <emilne@...hat.com>
Cc: "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "jrani@...estorage.com" <jrani@...estorage.com>,
 "randyj@...estorage.com" <randyj@...estorage.com>,
 "hare@...nel.org" <hare@...nel.org>
Subject: Re: [PATCH v6 1/1] nvme-multipath: implement "queue-depth" iopolicy

On 6/11/24 21:44, Chaitanya Kulkarni wrote:
>>    /*
>>     * List of workarounds for devices that required behavior not specified in
>>     * the standard.
>> @@ -195,6 +197,7 @@ enum {
>>    	NVME_REQ_CANCELLED		= (1 << 0),
>>    	NVME_REQ_USERCMD		= (1 << 1),
>>    	NVME_MPATH_IO_STATS		= (1 << 2),
>> +	NVME_MPATH_CNT_ACTIVE	= (1 << 3),
> nit:- please align above to existing code ...

Ok... there must be something wrong with my tab stop.... are we using 8 space tabs in linux?

Here's what I have in my .vimrc

set smartindent              " always set smartindenting on
set autoindent               " always set autoindenting on
set backspace=2              " Influences the working of <BS>, <Del>, CTRL-W and CTRL-U in Insert mode.
set noexpandtab              " insert tabs instead of spaces
set textwidth=0              " Don't wrap words by default
set shiftwidth=4 smarttab    " number of spaces to use for each step of indent
set tabstop=4 softtabstop=0  " setting tab stops to be different from the indentation width

What is recommended setting for these ?

set shiftwidth=8 ?
set tabstop=8 ?

/John