linux-kernel - Re: [PATCH v4 0/2] hwmon: (ina2xx):Add Suppor for passing alert polarity from device tree to driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab648952-769a-42bf-b7bb-ee13b58f8794@roeck-us.net>
Date: Wed, 12 Jun 2024 07:18:06 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Krzysztof Kozlowski <krzk@...nel.org>, Amna Waseem
 <Amna.Waseem@...s.com>, Jean Delvare <jdelvare@...e.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...s.com
Subject: Re: [PATCH v4 0/2] hwmon: (ina2xx):Add Suppor for passing alert
 polarity from device tree to driver

On 6/11/24 23:44, Krzysztof Kozlowski wrote:
> On 12/06/2024 08:37, Amna Waseem wrote:
>> On 6/12/24 08:20, Krzysztof Kozlowski wrote:
>>> So you require someone to re-review?
>>
>> Yes that will be great if someone re-review.
> 
> You are joking, right? We have hundreds of other patches to take care of
> and you ignore review tag, so you get duplicated work from the same
> reviewer? That's huge waste of time and actually quite disrespectful to
> our time.
> 

I applied v3 of the devicetree patch (after comparing the two to make sure
there are no changes).

Amna, I would suggest to run checkpatch on your patches in the future
to find problems such as the following.

ERROR: trailing whitespace
#178: FILE: Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml:74:
+      the alert polarity to active-high. $

Thanks,
Guenter