linux-kernel - Re: [PATCH v6 1/2] devcoredump: Add dev_coredumpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zmm2jC2nx6gZ2WOn@intel.com>
Date: Wed, 12 Jun 2024 10:54:04 -0400
From: Rodrigo Vivi <rodrigo.vivi@...el.com>
To: Johannes Berg <johannes@...solutions.net>
CC: José Roberto de Souza <jose.souza@...el.com>,
	<linux-kernel@...r.kernel.org>, <intel-xe@...ts.freedesktop.org>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>, Mukesh Ojha
	<quic_mojha@...cinc.com>, Jonathan Cavitt <jonathan.cavitt@...el.com>
Subject: Re: [PATCH v6 1/2] devcoredump: Add dev_coredumpm_timeout()

On Wed, Jun 12, 2024 at 02:02:37PM +0200, Johannes Berg wrote:
> On Tue, 2024-06-11 at 10:47 -0700, José Roberto de Souza wrote:
> > Add function to set a custom coredump timeout.
> > 
> > For Xe driver usage, current 5 minutes timeout may be too short for
> > users to search and understand what needs to be done to capture
> > coredump to report bugs.
> > 
> > We have plans to automate(distribute a udev script) it but at the end
> > will be up to distros and users to pack it so having a option to
> > increase the timeout is a safer option.
> > 
> > v2:
> > - replace dev_coredump_timeout_set() by dev_coredumpm_timeout() (Mukesh)
> > 
> > v3:
> > - make dev_coredumpm() static inline (Johannes)
> > 
> > v5:
> > - rename DEVCOREDUMP_TIMEOUT -> DEVCD_TIMEOUT to avoid redefinition
> > in include/net/bluetooth/coredump.h
> > 
> > v6:
> > - fix definition of dev_coredumpm_timeout() when CONFIG_DEV_COREDUMP
> > is disabled
> 
> Got to v6, heh.
> 
> I still don't think this is _right_, but I guess I'm OK with giving you
> rope to hang yourself ;-)

I do see your point. But with the udev in place, 5 min or 1 hour it shouldn't
matter right? But for users without the udev script then a long time is better
to react and learn how to capture the very first GPU hang information.

> 
> Acked-by: Johannes Berg <johannes@...solutions.net>

Thank you

> 
> Seems like you really should've CC'ed Greg though since these things
> usually went through his tree, so if you want to take them through yours
> he really should be at least aware ...

Indeed

Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Greg, ack on getting it through drm?

> 
> johannes
>