linux-kernel - Re: [PATCH v2 08/16] maple_tree: print store type in mas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 10:29:18 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Sidhartha Kumar <sidhartha.kumar@...cle.com>
Cc: linux-kernel@...r.kernel.org, maple-tree@...ts.infradead.org,
        linux-mm@...ck.org, akpm@...ux-foundation.org, willy@...radead.org
Subject: Re: [PATCH v2 08/16] maple_tree: print store type in mas_dump()

* Sidhartha Kumar <sidhartha.kumar@...cle.com> [240607 14:53]:
> Knowing the store type of the maple state could be helpful for debugging.
> Have mas_dump() print mas->store_type.
> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>
> ---
>  lib/maple_tree.c | 39 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index a955316b6745..91b18eef81e1 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -7731,6 +7731,45 @@ void mas_dump(const struct ma_state *mas)
>  		break;
>  	}
>  
> +	pr_err("Store Type: ");
> +	switch (mas->store_type) {
> +	case wr_invalid:
> +		pr_err("invalid store type\n");
> +		break;
> +	case wr_new_root:
> +		pr_err("new_root\n");
> +		break;
> +	case wr_store_root:
> +		pr_err("store_root\n");
> +		break;
> +	case wr_exact_fit:
> +		pr_err("exact_fit\n");
> +		break;
> +	case wr_split_store:
> +		pr_err("split_store\n");
> +		break;
> +	case wr_slot_store:
> +		pr_err("slot_store\n");
> +		break;
> +	case wr_append:
> +		pr_err("append\n");
> +		break;
> +	case wr_node_store:
> +		pr_err("node_store\n");
> +		break;
> +	case wr_spanning_store:
> +		pr_err("spanning_store\n");
> +		break;
> +	case wr_rebalance:
> +		pr_err("rebalance\n");
> +		break;
> +	case wr_bnode:
> +		pr_err("write_bnode\n");
> +		break;
> +
> +	}
> +
> +

There is an extra new line here

>  	pr_err("[%u/%u] index=%lx last=%lx\n", mas->offset, mas->end,
>  	       mas->index, mas->last);
>  	pr_err("     min=%lx max=%lx alloc=%p, depth=%u, flags=%x\n",
> -- 
> 2.45.2
>