linux-kernel - Re: [PATCH net] gve: Clear napi->skb before dev_kfree_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <171828963116.5991.16090491063036449379.git-patchwork-notify@kernel.org>
Date: Thu, 13 Jun 2024 14:40:31 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Ziwei Xiao <ziweixiao@...gle.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, jeroendb@...gle.com,
 pkaligineedi@...gle.com, shailend@...gle.com, hramamurthy@...gle.com,
 willemb@...gle.com, rushilg@...gle.com, bcf@...gle.com, csully@...gle.com,
 linux-kernel@...r.kernel.org, stable@...nel.org, stable@...r.kernel.org
Subject: Re: [PATCH net] gve: Clear napi->skb before dev_kfree_skb_any()

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 12 Jun 2024 00:16:54 +0000 you wrote:
> gve_rx_free_skb incorrectly leaves napi->skb referencing an skb after it
> is freed with dev_kfree_skb_any(). This can result in a subsequent call
> to napi_get_frags returning a dangling pointer.
> 
> Fix this by clearing napi->skb before the skb is freed.
> 
> Fixes: 9b8dd5e5ea48 ("gve: DQO: Add RX path")
> Cc: stable@...r.kernel.org
> Reported-by: Shailend Chand <shailend@...gle.com>
> Signed-off-by: Ziwei Xiao <ziweixiao@...gle.com>
> Reviewed-by: Harshitha Ramamurthy <hramamurthy@...gle.com>
> Reviewed-by: Shailend Chand <shailend@...gle.com>
> Reviewed-by: Praveen Kaligineedi <pkaligineedi@...gle.com>
> 
> [...]

Here is the summary with links:
  - [net] gve: Clear napi->skb before dev_kfree_skb_any()
    https://git.kernel.org/netdev/net/c/6f4d93b78ade

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html