linux-kernel - Re: [PATCH 2/5] PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 17:42:19 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 linux-pci@...r.kernel.org, linux-omap@...r.kernel.org,
 linux-tegra@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 linux-arm-kernel@...s.com, linux-arm-kernel@...ts.infradead.org,
 imx@...ts.linux.dev, mhi@...ts.linux.dev, Bjorn Helgaas
 <bhelgaas@...gle.com>, Fabio Estevam <festevam@...il.com>,
 Jesper Nilsson <jesper.nilsson@...s.com>, Jingoo Han <jingoohan1@...il.com>,
 Jonathan Hunter <jonathanh@...dia.com>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Lucas Stach <l.stach@...gutronix.de>,
 Marek Vasut <marek.vasut+renesas@...il.com>,
 Masami Hiramatsu <mhiramat@...nel.org>, Minghuan Lian
 <minghuan.Lian@....com>, Mingkai Hu <mingkai.hu@....com>,
 Niklas Cassel <cassel@...nel.org>, Richard Zhu <hongxing.zhu@....com>,
 Rob Herring <robh@...nel.org>, Roy Zang <roy.zang@....com>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Siddharth Vadapalli <s-vadapalli@...com>,
 Srikanth Thokala <srikanth.thokala@...el.com>,
 Thierry Reding <thierry.reding@...il.com>,
 Vignesh Raghavendra <vigneshr@...com>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel@...gutronix.de
Subject: Re: [PATCH 2/5] PCI: endpoint: Introduce 'epc_deinit' event and
 notify the EPF drivers

…
> +++ b/drivers/pci/endpoint/pci-epc-core.c
…
> +void pci_epc_deinit_notify(struct pci_epc *epc)
> +{
…
> +	mutex_lock(&epc->list_lock);
> +	list_for_each_entry(epf, &epc->pci_epf, list) {
> +		mutex_lock(&epf->lock);
> +		if (epf->event_ops && epf->event_ops->epc_deinit)
> +			epf->event_ops->epc_deinit(epf);
> +		mutex_unlock(&epf->lock);
> +	}
> +	epc->init_complete = false;
> +	mutex_unlock(&epc->list_lock);
> +}
…

Would you become interested to apply lock guards?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196

Regards,
Markus