linux-kernel - Re: [PATCH] virt: tdx-guest: Fix the decrypted failure memory free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <32eddae1-14bf-42dd-afdd-7dca8bc8a131@intel.com>
Date: Thu, 13 Jun 2024 09:07:39 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Li RongQing <lirongqing@...du.com>, kirill.shutemov@...ux.intel.com,
 dave.hansen@...ux.intel.com, x86@...nel.org, linux-coco@...ts.linux.dev,
 "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virt: tdx-guest: Fix the decrypted failure memory free

On 6/13/24 04:19, Li RongQing wrote:
> When set_memory_decrypted() fails, the memory should be encrypted
> via set_memory_encrypted(); if encrypting the memory fails, leak it

Please, always cc LKML on this stuff.

Second, Rick was looking in this area, but I'm not sure we ever applied
his patches.  The idea was to never leak memory silently in these
failures.  Doesn't this silently leak memory?