Message-ID: <ZmphzTKiDDYkPPP+@xsang-OptiPlex-9020>
Date: Thu, 13 Jun 2024 11:04:45 +0800
From: Oliver Sang <oliver.sang@...el.com>
To: Ian Rogers <irogers@...gle.com>
CC: <oe-lkp@...ts.linux.dev>, <lkp@...el.com>,
	<linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Weilin
 Wang" <weilin.wang@...el.com>, Peter Zijlstra <peterz@...radead.org>, "Ingo
 Molnar" <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa
	<jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, Kan Liang
	<kan.liang@...ux.intel.com>, Jing Zhang <renyu.zj@...ux.alibaba.com>, "John
 Garry" <john.g.garry@...cle.com>, Sandipan Das <sandipan.das@....com>,
	<oliver.sang@...el.com>
Subject: Re: [PATCH v2 2/2] perf jevents: Autogenerate empty-pmu-events.c

hi, Ian,

On Wed, Jun 12, 2024 at 02:46:43PM -0700, Ian Rogers wrote:
> On Mon, Jun 3, 2024 at 8:46 AM Ian Rogers <irogers@...gle.com> wrote:
> >
> > On Mon, Jun 3, 2024 at 7:19 AM Oliver Sang <oliver.sang@...el.com> wrote:
> [...]
> > > I tried below patch
> > >
> > > commit a79a41133a41adc2d69c8f603c7d880b3796cbf7
> > > Author: 0day robot <lkp@...el.com>
> > > Date:   Mon Jun 3 16:35:45 2024 +0800
> > >
> > >     fix from Ian Rogers: invoke "diff -w -u" instead of "diff -u"
> > >
> > > diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
> > > index c3fa43c497069..54d19b492db5c 100644
> > > --- a/tools/perf/pmu-events/Build
> > > +++ b/tools/perf/pmu-events/Build
> > > @@ -39,7 +39,7 @@ $(TEST_EMPTY_PMU_EVENTS_C): $(JSON) $(JSON_TEST) $(JEVENTS_PY) $(METRIC_PY) $(ME
> > >
> > >  $(EMPTY_PMU_EVENTS_TEST_LOG): $(EMPTY_PMU_EVENTS_C) $(TEST_EMPTY_PMU_EVENTS_C)
> > >         $(call rule_mkdir)
> > > -       $(Q)$(call echo-cmd,test)diff -u $? 2> $@ || (cat $@ && false)
> > > +       $(Q)$(call echo-cmd,test)diff -w -u $? 2> $@ || (cat $@ && false)
> > >
> > >  $(PMU_EVENTS_C): $(JSON) $(JSON_TEST) $(JEVENTS_PY) $(METRIC_PY) $(METRIC_TEST_LOG) $(EMPTY_PMU_EVENTS_TEST_LOG)
> > >         $(call rule_mkdir)
> > >
> > >
> > > but make still failed. I still saw below in our build log
> > >
> > > --- pmu-events/empty-pmu-events.c       2024-06-03 08:41:16.000000000 +0000
> > > +++ pmu-events/test-empty-pmu-events.c  2024-06-03 13:47:19.522463482 +0000
> > > @@ -136,7 +136,7 @@
> > >  { 2623 }, /* M3\000\0001 / M3\000\000\000\000\000\000\000\00000 */
> > >  { 2078 }, /* cache_miss_cycles\000group1\000dcache_miss_cpi + icache_miss_cycles\000\000\000\000\000\000\000\00000 */
> > >  { 1947 }, /* dcache_miss_cpi\000\000l1d\\-loads\\-misses / inst_retired.any\000\000\000\000\000\000\000\00000 */
> > > -{ 2011 }, /* icache_miss_cycles\000\000l1i\\-loads\\-misses / inst_retiredany\000\000\000\000\000\000\000\00000 */
> > > +{ 2011 }, /* icache_miss_cycles\000\000l1i\\-loads\\-misses / inst_retired.any\000\000\000\000\000\000\000\00000 */
> > >
> > >  };
> > >
> > >
> > > I will try to get generated test-empty-pmu-events.c tomorrow.
> >
> > Thanks Oliver, if you could get the environment variables that would
> > probably also be useful.
> 
> Hi Oliver, any update on this?

sorry for late.

I pack whole pmu-events folder as attached pmu-events.tar.gz

below is the env variables

declare -x ARCH="x86_64"
declare -x BENCHMARK_ROOT="/lkp/benchmarks"
declare -x BOOT_IMAGE="/pkg/linux/x86_64-rhel-8.3-bpf/gcc-13/3249f8b84526d3b69162812908c257ee9816a237/vmlinuz-6.9.0-11004-g3249f8b84526"
declare -x DBUS_SESSION_BUS_ADDRESS="unix:path=/run/user/0/bus"
declare -x HISTSIZE="51200"
declare -x HOME="/root"
declare -x HOSTNAME="lkp-spr-2sp1"
declare -x LANG="en_US.UTF-8"
declare -x LC_ADDRESS="zh_CN.UTF-8"
declare -x LC_IDENTIFICATION="zh_CN.UTF-8"
declare -x LC_MEASUREMENT="zh_CN.UTF-8"
declare -x LC_MONETARY="zh_CN.UTF-8"
declare -x LC_NAME="zh_CN.UTF-8"
declare -x LC_NUMERIC="zh_CN.UTF-8"
declare -x LC_PAPER="zh_CN.UTF-8"
declare -x LC_TELEPHONE="zh_CN.UTF-8"
declare -x LC_TIME="zh_CN.UTF-8"
declare -x LESS="-MRiqscj5"
declare -x LESSCLOSE="/usr/bin/lesspipe %s %s"
declare -x LESSOPEN="| /usr/bin/lesspipe %s"
declare -x LOGNAME="root"
declare -x LS_COLORS
declare -x MOTD_SHOWN="pam"
declare -x OLDPWD="/usr/src/perf_selftests-x86_64-rhel-8.3-bpf-3249f8b84526d3b69162812908c257ee9816a237/tools/perf/pmu-events"
declare -x PAGER="less"
declare -x PATH="/root/bin:/usr/local/sbin:/usr/local/bin:/usr/lib/git-core:/usr/sbin:/usr/bin:/sbin:/bin:/lkp/xsang/src/bin"
declare -x PS1="\\[\\033[0m\\]\\[\\033[1;30m\\]\\[\\033[1;31m\\]\\u\\[\\033[1;30m\\]@\\[\\033[1;34m\\]\\h\\[\\033[1;30m\\] \\[\\033[0;37m\\033[4m\\]\\w\\[\\033[0m\\]\\[\\033[1;30m\\]\\[\\033[0;31m\\]# \\[\\033[0;37m\\]"
declare -x PS2="\\[\\033[1;30m\\]> \\[\\033[0;37m\\]"
declare -x PWD="/usr/src/perf_selftests-x86_64-rhel-8.3-bpf-3249f8b84526d3b69162812908c257ee9816a237/tools/perf"
declare -x RESULT_ROOT="/result/perf-sanity-tests/gcc/lkp-spr-2sp1/debian-12-x86_64-20240206.cgz/x86_64-rhel-8.3-bpf/gcc-13/3249f8b84526d3b69162812908c257ee9816a237/20"
declare -x SHELL="/bin/bash"
declare -x SHLVL="1"
declare -x TERM="linux"
declare -x USER="root"
declare -x XAUTHORITY="/root/.Xauthority"
declare -x XDG_RUNTIME_DIR="/run/user/0"
declare -x XDG_SESSION_CLASS="user"
declare -x XDG_SESSION_ID="2"
declare -x XDG_SESSION_TYPE="tty"
declare -x _rt="/result/perf-sanity-tests/gcc/lkp-spr-2sp1/debian-12-x86_64-20240206.cgz/x86_64-rhel-8.3-bpf/gcc-13/3249f8b84526d3b69162812908c257ee9816a237"
declare -x acpi_rsdp="0x777fe014"
declare -x apic="debug"
declare -x arch="x86_64"
declare -x base_commit="a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6"
declare -x bootloader_append=$'root=/dev/ram0\nRESULT_ROOT=/result/perf-sanity-tests/gcc/lkp-spr-2sp1/debian-12-x86_64-20240206.cgz/x86_64-rhel-8.3-bpf/gcc-13/3249f8b84526d3b69162812908c257ee9816a237/20\nBOOT_IMAGE=/pkg/linux/x86_64-rhel-8.3-bpf/gcc-13/3249f8b84526d3b69162812908c257ee9816a237/vmlinuz-6.9.0-11004-g3249f8b84526\nbranch=linux-review/Ian-Rogers/perf-jevents-Autogenerate-empty-pmu-events-c/20240525-093240\njob=/lkp/jobs/scheduled/lkp-spr-2sp1/perf-sanity-tests-gcc-debian-12-x86_64-20240206.cgz-3249f8b84526-20240613-8245-291s0m-0.yaml\nuser=xsang\nARCH=x86_64\nkconfig=x86_64-rhel-8.3-bpf\ncommit=3249f8b84526d3b69162812908c257ee9816a237\nnmi_watchdog=0\nintremap=posted_msi\nacpi_rsdp=0x777fe014\nmax_uptime=1200\nLKP_SERVER=internal-lkp-server\nnokaslr\nselinux=0\ndebug\napic=debug\nsysrq_always_enabled\nrcupdate.rcu_cpu_stall_timeout=100\nnet.ifnames=0\nprintk.devkmsg=on\npanic=-1\nsoftlockup_panic=1\nnmi_watchdog=panic\noops=panic\nload_ramdisk=2\nprompt_ramdisk=0\ndrbd.minor_count=8\nsystemd.log_level=err\nignore_loglevel\nconsole=tty0\nearlyprintk=ttyS0,115200\nconsole=ttyS0,115200\nvga=normal\nrw'
declare -x branch="linux-review/Ian-Rogers/perf-jevents-Autogenerate-empty-pmu-events-c/20240525-093240"
declare -x brand="Intel(R) Xeon(R) Platinum 8480+"
declare -x category="functional"
declare -x commit="3249f8b84526d3b69162812908c257ee9816a237"
declare -x compiler="gcc-13"
declare -x console="tty0"
declare -x enqueue_time="2024-06-13 09:44:38 +0800"
declare -x head_commit="e2c0a3562d2f7822c36edaf8449abbb95db9bd86"
declare -x id="321340fbc98d04a39a68e8fdcfd2415a4c02fe1b"
declare -x initrd="/osimage/debian/debian-12-x86_64-20240206.cgz"
declare -x initrds="linux_perf"
declare -x intremap="posted_msi"
declare -x ip="::::lkp-spr-2sp1::dhcp"
declare -x job="/lkp/jobs/scheduled/lkp-spr-2sp1/perf-sanity-tests-gcc-debian-12-x86_64-20240206.cgz-3249f8b84526-20240613-8245-291s0m-0.yaml"
declare -x job_file="/lkp/jobs/queued/int/lkp-spr-2sp1/perf-sanity-tests-gcc-debian-12-x86_64-20240206.cgz-3249f8b84526-20240613-8245-291s0m-0.yaml"
declare -x job_initrd="/lkp/jobs/scheduled/lkp-spr-2sp1/perf-sanity-tests-gcc-debian-12-x86_64-20240206.cgz-3249f8b84526-20240613-8245-291s0m-0.cgz"
declare -x job_origin="perf-sanity-tests.yaml"
declare -x kbuild_queue_analysis="1"
declare -x kconfig="x86_64-rhel-8.3-bpf"
declare -x kernel="/pkg/linux/x86_64-rhel-8.3-bpf/gcc-13/3249f8b84526d3b69162812908c257ee9816a237/vmlinuz-6.9.0-11004-g3249f8b84526"
declare -x kernel_cmdline_hw="acpi_rsdp=0x777fe014"
declare -x last_kernel="5.9.0-2-amd64"
declare -x linux_perf_initrd="/pkg/linux/x86_64-rhel-8.3-bpf/gcc-13/3249f8b84526d3b69162812908c257ee9816a237/linux-perf.cgz"
declare -x lkp_initrd="/osimage/user/xsang/lkp-x86_64.cgz"
declare -x load_ramdisk="2"
declare -x max_uptime="1200"
declare -x memory="256G"
declare -x model="Sapphire Rapids"
declare -x modules_initrd="/pkg/linux/x86_64-rhel-8.3-bpf/gcc-13/3249f8b84526d3b69162812908c257ee9816a237/modules.cgz"
declare -x need_memory="2G"
declare -x nmi_watchdog="panic"
declare -x nr_cpu="224"
declare -x nr_node="2"
declare -x nr_ssd_partitions="6"
declare -x oops="panic"
declare -x panic="-1"
declare -x prompt_ramdisk="0"
declare -x queue="int"
declare -x queue_cmdline_keys="user"
declare -x queuer_version="/lkp/xsang/.src-20240613-094320"
declare -x result_root="/result/perf-sanity-tests/gcc/lkp-spr-2sp1/debian-12-x86_64-20240206.cgz/x86_64-rhel-8.3-bpf/gcc-13/3249f8b84526d3b69162812908c257ee9816a237/20"
declare -x root="/dev/ram0"
declare -x selinux="0"
declare -x site="inn"
declare -x softlockup_panic="1"
declare -x suite="perf-sanity-tests"
declare -x tbox_group="lkp-spr-2sp1"
declare -x testbox="lkp-spr-2sp1"
declare -x testcase="perf-sanity-tests"
declare -x ucode="0x2b0004b1"
declare -x ucode_initrd="/osimage/ucode/intel-ucode-20230906.cgz"
declare -x vga="normal"


> 
> Thanks,
> Ian

Download attachment "pmu-events.tar.gz" of type "application/gzip" (1871958 bytes)

Powered by blists - more mailing lists