linux-kernel - Re: [PATCH] dm: Add support for escaped characters in str_field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240613163015.38097-1-jain.abhinav177@gmail.com>
Date: Thu, 13 Jun 2024 16:30:15 +0000
From: Abhinav Jain <jain.abhinav177@...il.com>
To: bmarzins@...hat.com
Cc: agk@...hat.com,
	dm-devel@...ts.linux.dev,
	jain.abhinav177@...il.com,
	javier.carrasco.cruz@...il.com,
	linux-kernel@...r.kernel.org,
	mpatocka@...hat.com,
	skhan@...uxfoundation.org,
	snitzer@...nel.org
Subject: Re: [PATCH] dm: Add support for escaped characters in str_field_delimit()

On Mon, Jun 10, 2024 at 01:11:40PM -0400, Benjamin Marzinski wrote:
> This doesn't do anything to the escape character. Presumably you want to
> pass the field containing a separator down to dm_eary_create(). But you
> don't want to pass the escape character itself.
>
> To work correctly, this code needs to remove all those escape characters
> that come before separators. It probably needs to do something like:
>
> 1. Find a next non-escaped separator and change it to NULL, so you have
> your field string.
>
> 2. Find all the escaped separators in the field string, and shift the
> rest of the string over to overwrite the escape character with the rest
> of the string.
>
> -Ben

Hi Ben,

I realised I should have done better testing after processing your feedback.
I have accordingly modified the code and shared a v2:
https://lore.kernel.org/all/20240613162632.38065-1-jain.abhinav177@gmail.com/

Please help review and provide feedback again. Thanks.