linux-kernel - Re: [PATCH] soc: qcom: icc-bwmon: Fix refcount imbalance seen during bwmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 19:29:58 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Sibi Sankar <quic_sibis@...cinc.com>, andersson@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, thara.gopinath@...il.com
Cc: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 quic_rgottimu@...cinc.com, quic_kshivnan@...cinc.com, abel.vesa@...aro.org
Subject: Re: [PATCH] soc: qcom: icc-bwmon: Fix refcount imbalance seen during
 bwmon_remove



On 6/13/24 18:45, Sibi Sankar wrote:
> The following warning is seen during bwmon_remove due to refcount
> imbalance, fix this by releasing the OPPs after use.
> 
> Logs:
> WARNING: at drivers/opp/core.c:1640 _opp_table_kref_release+0x150/0x158
> Hardware name: Qualcomm Technologies, Inc. X1E80100 CRD (DT)
> ...
> Call trace:
> _opp_table_kref_release+0x150/0x158
> dev_pm_opp_remove_table+0x100/0x1b4
> devm_pm_opp_of_table_release+0x10/0x1c
> devm_action_release+0x14/0x20
> devres_release_all+0xa4/0x104
> device_unbind_cleanup+0x18/0x60
> device_release_driver_internal+0x1ec/0x228
> driver_detach+0x50/0x98
> bus_remove_driver+0x6c/0xbc
> driver_unregister+0x30/0x60
> platform_driver_unregister+0x14/0x20
> bwmon_driver_exit+0x18/0x524 [icc_bwmon]
> __arm64_sys_delete_module+0x184/0x264
> invoke_syscall+0x48/0x118
> el0_svc_common.constprop.0+0xc8/0xe8
> do_el0_svc+0x20/0x2c
> el0_svc+0x34/0xdc
> el0t_64_sync_handler+0x13c/0x158
> el0t_64_sync+0x190/0x194
> --[ end trace 0000000000000000 ]---
> 
> Fixes: 0276f69f13e2 ("soc: qcom: icc-bwmon: Set default thresholds dynamically")
> Fixes: b9c2ae6cac40 ("soc: qcom: icc-bwmon: Add bandwidth monitoring driver")
> Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad