linux-kernel - Re: [PATCH v11 2/9] cpufreq: simplify boolean parsing with kstrtobool in store function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 12:55:24 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Perry Yuan <perry.yuan@....com>, gautham.shenoy@....com,
 Borislav.Petkov@....com
Cc: rafael.j.wysocki@...el.com, viresh.kumar@...aro.org,
 Alexander.Deucher@....com, Xinmei.Huang@....com, Xiaojian.Du@....com,
 Li.Meng@....com, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 2/9] cpufreq: simplify boolean parsing with kstrtobool
 in store function

On 6/13/2024 02:25, Perry Yuan wrote:
> Update the cpufreq store function to use kstrtobool for parsing boolean
> values. This simplifies the code and improves readability by using a
> standard kernel function for boolean string conversion.
> 
> Signed-off-by: Perry Yuan <perry.yuan@....com>

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

> ---
>   drivers/cpufreq/cpufreq.c | 11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index a45aac17c20f..1fdabb660231 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -614,10 +614,9 @@ static ssize_t show_boost(struct kobject *kobj,
>   static ssize_t store_boost(struct kobject *kobj, struct kobj_attribute *attr,
>   			   const char *buf, size_t count)
>   {
> -	int ret, enable;
> +	bool enable;
>   
> -	ret = sscanf(buf, "%d", &enable);
> -	if (ret != 1 || enable < 0 || enable > 1)
> +	if (kstrtobool(buf, &enable))
>   		return -EINVAL;
>   
>   	if (cpufreq_boost_trigger_state(enable)) {
> @@ -641,10 +640,10 @@ static ssize_t show_local_boost(struct cpufreq_policy *policy, char *buf)
>   static ssize_t store_local_boost(struct cpufreq_policy *policy,
>   				 const char *buf, size_t count)
>   {
> -	int ret, enable;
> +	int ret;
> +	bool enable;
>   
> -	ret = kstrtoint(buf, 10, &enable);
> -	if (ret || enable < 0 || enable > 1)
> +	if (kstrtobool(buf, &enable))
>   		return -EINVAL;
>   
>   	if (!cpufreq_driver->boost_enabled)