linux-kernel - Re: [PATCH v6 2/2] pstore/ramoops: Add ramoops.mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a6bd674-48ca-f7fc-d572-51e52e6899d9@igalia.com>
Date: Thu, 13 Jun 2024 15:19:50 -0300
From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To: Steven Rostedt <rostedt@...dmis.org>, Mike Rapoport <rppt@...nel.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>,
 linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org,
 Mark Rutland <mark.rutland@....com>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Vincent Donnefort <vdonnefort@...gle.com>,
 Joel Fernandes <joel@...lfernandes.org>,
 Daniel Bristot de Oliveira <bristot@...hat.com>,
 Ingo Molnar <mingo@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 suleiman@...gle.com, Thomas Gleixner <tglx@...utronix.de>,
 Vineeth Pillai <vineeth@...byteword.org>,
 Youssef Esmat <youssefesmat@...gle.com>,
 Beau Belgrave <beaub@...ux.microsoft.com>, Alexander Graf <graf@...zon.com>,
 Baoquan He <bhe@...hat.com>, Borislav Petkov <bp@...en8.de>,
 "Paul E. McKenney" <paulmck@...nel.org>, David Howells <dhowells@...hat.com>
Subject: Re: [PATCH v6 2/2] pstore/ramoops: Add ramoops.mem_name= command line
 option

Thanks Steve, re-tested in my VM and it's working fine.
Just a minor below...

On 13/06/2024 12:55, Steven Rostedt wrote:
> [...]
> + D. Using a region of memory reserved via ``reserve_mem`` command line
> +    parameter. The address and size will be defined by the ``reserve_mem``
> +    parameter. Note, that ``reserve_mem`` may not always allocate memory
> +    in the same location, and cannot be relied upon. Testing will need
> +    to be done, and it may not work on every machine, nor every kernel.
> +    Consider this a "best effort" approach. The ``reserve_mem`` option
> +    takes a size, alignment and name as arguments. The name is used
> +    to map the memory to a label that can be retrieved by ramoops.
> +
> +	reserver_mem=2M:4096:oops  ramoops.mem_name=oops
> +

Likely this could be fixed on merge, to avoid another version, but...

s/reserver_mem/reserve_mem

Cheers!