linux-kernel - Re: [PATCH v2 00/25] Enable FRED with KVM VMX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zms8lRn20MGVVN9h@google.com>
Date: Thu, 13 Jun 2024 11:38:13 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Shan Kang <shan.kang@...el.com>
Cc: Xin3 Li <xin3.li@...el.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, 
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>, "corbet@....net" <corbet@....net>, 
	"x86@...nel.org" <x86@...nel.org>, 
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, "vkuznets@...hat.com" <vkuznets@...hat.com>, 
	"bp@...en8.de" <bp@...en8.de>, "mingo@...hat.com" <mingo@...hat.com>, 
	"tglx@...utronix.de" <tglx@...utronix.de>, "hpa@...or.com" <hpa@...or.com>, 
	"pbonzini@...hat.com" <pbonzini@...hat.com>, "peterz@...radead.org" <peterz@...radead.org>, 
	"shuah@...nel.org" <shuah@...nel.org>, Ravi V Shankar <ravi.v.shankar@...el.com>, 
	"xin@...or.com" <xin@...or.com>
Subject: Re: [PATCH v2 00/25] Enable FRED with KVM VMX

On Wed, Mar 27, 2024, Shan Kang wrote:
> On Wed, 2024-02-07 at 09:26 -0800, Xin Li wrote:
> > This patch set enables the Intel flexible return and event delivery
> > (FRED) architecture with KVM VMX to allow guests to utilize FRED.
> > 
> We tested this FRED KVM patch set on a 7th Intel(R) Core(TM) CPU and the Intel 
> Simics® Simulator with the following four configurations:

That likely provides coverage for the happy cases, but I doubt it provides negative
testing, e.g. for VM-Enter consistency checks.  KVM-Unit-Tests are currently the
best choice for concistency checks (unfortunately).

And given the insanity of event re-injection, KVM selftests needs a dedicated test
for that, and another for the interactions with nVMX, e.g. a la svm_nested_soft_inject_test.c.

I haven't looked too closely at the selftest that's already provided, but my
suspicion is that we'll want multiple tests, or alternatively one test that
uses KVM_ONE_VCPU_TEST_SUITE().