linux-kernel - Re: [PATCH net-next v1] lan78xx: lan7801 MAC support with lan8841

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6eec7a37-13d0-4451-9b32-4b031c942aa1@lunn.ch>
Date: Thu, 13 Jun 2024 22:46:13 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Rengarajan S <rengarajan.s@...rochip.com>
Cc: woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v1] lan78xx: lan7801 MAC support with lan8841

On Tue, Jun 11, 2024 at 03:12:33PM +0530, Rengarajan S wrote:
> Add lan7801 MAC only support with lan8841. The PHY fixup is registered
> for lan8841 and the initializations are done using lan8835_fixup since
> the register configs are similar for both lann8841 and lan8835.

What exactly does this fixup do?

Looking at it, what protects it from being used on some other device
which also happens to use the same PHY? Is there something to
guarantee:

struct lan78xx_net *dev = netdev_priv(phydev->attached_dev);

really is a lan78xx_net * ?

   Andrew