linux-kernel - Re: [PATCH] PCI: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 17:20:32 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] PCI: add missing MODULE_DESCRIPTION() macros

On Mon, Jun 10, 2024 at 06:21:16PM -0700, Jeff Johnson wrote:
> When ARCH=x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-stub.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-pf-stub.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>

Applied to pci/misc for v6.11, with updates to the text:

> ---
>  drivers/pci/pci-pf-stub.c | 1 +
>  drivers/pci/pci-stub.c    | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/pci-pf-stub.c b/drivers/pci/pci-pf-stub.c
> index 45855a5e9fca..04815fcb0ce7 100644
> --- a/drivers/pci/pci-pf-stub.c
> +++ b/drivers/pci/pci-pf-stub.c
> @@ -39,4 +39,5 @@ static struct pci_driver pf_stub_driver = {
>  };
>  module_pci_driver(pf_stub_driver);
>  
> +MODULE_DESCRIPTION("Simple stub driver for PCI SR-IOV PF device");

+MODULE_DESCRIPTION("SR-IOV PF stub driver with no functionality");

>  MODULE_LICENSE("GPL");
> diff --git a/drivers/pci/pci-stub.c b/drivers/pci/pci-stub.c
> index d1f4c1ce7bd1..d4fec791b321 100644
> --- a/drivers/pci/pci-stub.c
> +++ b/drivers/pci/pci-stub.c
> @@ -92,5 +92,6 @@ static void __exit pci_stub_exit(void)
>  module_init(pci_stub_init);
>  module_exit(pci_stub_exit);
>  
> +MODULE_DESCRIPTION("Simple stub driver to reserve a PCI device");

+MODULE_DESCRIPTION("VM device assignment stub driver");

>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Chris Wright <chrisw@...s-sol.org>");
> 
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240610-md-drivers-pci-831cb8f308a9
>