linux-kernel - Re: [PATCH] hwmon: (pmbus/mp9941) Add missing bitfield header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 16:40:29 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Noah Wang <noahwang.wang@...look.com>, Jean Delvare <jdelvare@...e.com>
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] hwmon: (pmbus/mp9941) Add missing bitfield header

On 6/13/24 14:57, Javier Carrasco wrote:
> The recently added driver for the MP99441 is missing the bitfield
> header. Without it, gcc fails to find FIELD_PREP and FIELD_GET.
> 
> Add the missing <linux/bitfield.h>
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: c16fa6967781 ("hwmon: add MP9941 driver")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
> This patch fixes the errors reported by the kernel test robot about
> the MP9941 in the hwmon subsystem. It does not close the error report
> from the BUILD REGRESSION 6906a84c482f098d31486df8dc98cead21cce2d0,
> that includes, among others, this issue. The report attached to the
> mentioned build regression actually covers a different bug.
> Hence why no Closes: tag was added.

Already fixed in hwmon-next, but thanks.

Guenter


> ---
>   drivers/hwmon/pmbus/mp9941.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/pmbus/mp9941.c b/drivers/hwmon/pmbus/mp9941.c
> index b7b0eda5b552..475221b738f5 100644
> --- a/drivers/hwmon/pmbus/mp9941.c
> +++ b/drivers/hwmon/pmbus/mp9941.c
> @@ -3,6 +3,7 @@
>    * Hardware monitoring driver for MPS Multi-phase Digital VR Controllers(MP9941)
>    */
>   
> +#include <linux/bitfield.h>
>   #include <linux/i2c.h>
>   #include <linux/module.h>
>   #include <linux/of_device.h>
> 
> ---
> base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0
> change-id: 20240613-mp9941_bitfield_h-59cca83ae233
> 
> Best regards,