linux-kernel - Re: [PATCH v2] mmc: Convert from tasklet to BH workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17eadeab-ecd5-4302-94b3-bbcf4f9d8dfc@intel.com>
Date: Thu, 13 Jun 2024 08:09:19 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Allen Pais <allen.lkml@...il.com>,
 Aubin Constans <aubin.constans@...rochip.com>,
 Ulf Hansson <ulf.hansson@...aro.org>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>,
 Manuel Lauss <manuel.lauss@...il.com>,
 Michał Mirosław <mirq-linux@...e.qmqm.pl>,
 Jaehoon Chung <jh80.chung@...sung.com>, Aaro Koskinen
 <aaro.koskinen@....fi>, Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>, Ray Jui
 <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Alex Dubov <oakad@...oo.com>,
 Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
 Masami Hiramatsu <mhiramat@...nel.org>, Bruce Chang <brucechang@....com.tw>,
 Harald Welte <HaraldWelte@...tech.com>, Pierre Ossman <pierre@...man.eu>
Cc: Christian Loehle <christian.loehle@....com>, linux-mmc@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-omap@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2] mmc: Convert from tasklet to BH workqueue

On 13/06/24 02:49, Allen Pais wrote:
> The only generic interface to execute asynchronously in the BH context is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH workqueue
> behaves similarly to regular workqueues except that the queued work items
> are executed in the BH context.
> 
> This patch converts drivers/mmc/* from tasklet to BH workqueue.
> 
> Based on the work done by Tejun Heo <tj@...nel.org>
> 
> Tested-by: Christian Loehle <christian.loehle@....com>
> Tested-by: Aubin Constans <aubin.constans@...rochip.com>
> Acked-by: Aubin Constans <aubin.constans@...rochip.com>
> Acked-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> Reviewed-by: Christian Loehle <christian.loehle@....com>
> Signed-off-by: Allen Pais <allen.lkml@...il.com>
> ---
> v2:
>    - fixed patch styling issues
>    - rename work to bh_work
> 
> Link to v1:
> https://lore.kernel.org/all/20240327160314.9982-10-apais@linux.microsoft.com/
> 

[SNIP]

> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index cb9152c6a65d..9c215db81b2b 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -107,7 +107,7 @@ static void sdhci_bcm_kona_sd_init(struct sdhci_host *host)
>   * Software emulation of the SD card insertion/removal. Set insert=1 for insert
>   * and insert=0 for removal. The card detection is done by GPIO. For Broadcom
>   * IP to function properly the bit 0 of CORESTAT register needs to be set/reset
> - * to generate the CD IRQ handled in sdhci.c which schedules card_tasklet.
> + * to generate the CD IRQ handled in sdhci.c which schedules card_bh_work.

The comment was stale because sdhci.c has not had a card_tasklet for
a long time.  Just drop the " which schedules card_tasklet"

>   */
>  static int sdhci_bcm_kona_sd_card_emulate(struct sdhci_host *host, int insert)
>  {