linux-kernel - Re: [PATCH RFC -next 1/7] kernfs: export pr_cont_kernfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024061314-moodiness-snowflake-14c5@gregkh>
Date: Thu, 13 Jun 2024 07:55:51 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: axboe@...nel.dk, tj@...nel.org, josef@...icpanda.com,
	lizefan.x@...edance.com, hannes@...xchg.org,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	cgroups@...r.kernel.org, yukuai3@...wei.com, yi.zhang@...wei.com,
	yangerkun@...wei.com
Subject: Re: [PATCH RFC -next 1/7] kernfs: export pr_cont_kernfs_path()

On Thu, Jun 13, 2024 at 09:49:31AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> This helper is used in iocost, prepare to build iocost as kernel module.
> 
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
>  fs/kernfs/dir.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
> index 458519e416fe..84ad163a4281 100644
> --- a/fs/kernfs/dir.c
> +++ b/fs/kernfs/dir.c
> @@ -279,6 +279,7 @@ void pr_cont_kernfs_path(struct kernfs_node *kn)
>  out:
>  	spin_unlock_irqrestore(&kernfs_pr_cont_lock, flags);
>  }
> +EXPORT_SYMBOL_GPL(pr_cont_kernfs_path);

This isn't the helper that needs to be exported, it's a include wrapper
that is using this for cgroups.  Please document this much better and
perhaps, just fix up the cgroups code instead?

thanks,

greg k-h