linux-kernel - Re: [EXT] Re: [PATCH 1/4] dt-bindings: firmware: secvio: Add device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a752a912-a328-49c8-b887-fa95512785cb@kernel.org>
Date: Thu, 13 Jun 2024 08:13:54 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Aisheng Dong <aisheng.dong@....com>, Vabhav Sharma
 <vabhav.sharma@....com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Franck Lenormand <franck.lenormand@....com>,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Peng Fan <peng.fan@....com>
Cc: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>, Varun Sethi <V.Sethi@....com>,
 Silvano Di Ninno <silvano.dininno@....com>,
 Pankaj Gupta <pankaj.gupta@....com>, Frank Li <frank.li@....com>,
 Daniel Baluta <daniel.baluta@....com>
Subject: Re: [EXT] Re: [PATCH 1/4] dt-bindings: firmware: secvio: Add device
 tree bindings

On 12/06/2024 09:20, Aisheng Dong wrote:
> Hi Krzysztof
> 
>> From: Krzysztof Kozlowski <krzk@...nel.org>
>> Sent: 2024年6月7日 15:08
>>
>> On 07/06/2024 06:58, Vabhav Sharma wrote:
>>>>
>>>> Missing SoC compatibles.
>>> Ok, I will use fsl,imx8dxl-sc-secvio
>>>>
>>>> So no, that's just abuse of DT to instantiate driver.
>>>>
>>>> NAK. Drop the binding.
>>> I will detail the dt binding to describe the real hardware
>>
>> Still looks like way just to instantiate driver. Why it cannot be part of existing
>> firmware SCU node?
>>
> 
> Technically yes. But SCU case is a little bit complicated as there're many
> functions and all of them are already added as sub nodes in SCU node
> for consistency and handling platform difference.
> 
> I guess some of them, e.g. rtc, could be part of SCU node (reuse) while
> some couldn't. e.g. pinctrl
> Do you want us to only make secvio reuse existing SCU node? 

Yes

> This might look a bit strange to the existing sub nodes.

Nothing strange/unusual to me.

> 
> BTW, even we can reuse SCU node for secvio function, we still need update
> binding doc to add extra property 'nvmem' for secvio.

Sure.



Best regards,
Krzysztof