linux-kernel - Re: [PATCH v3 2/3] media: i2c: Add GT97xx VCM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <171823714905.1550852.13442340621133903705@ping.linuxembedded.co.uk>
Date: Thu, 13 Jun 2024 01:05:49 +0100
From: Kieran Bingham <kieran.bingham@...asonboard.com>
To: Zhi Mao 毛智 <zhi.mao@...iatek.com>, angelogioacchino.delregno@...labora.com, conor+dt@...nel.org, krzk+dt@...nel.org, mchehab@...nel.org, robh@...nel.org, dongchun.zhu@...iatek.com
Cc: heiko@...ech.de <heiko@...ech.de>, linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>, laurent.pinchart+renesas@...asonboard.com <laurent.pinchart+renesas@...asonboard.com>, yunkec@...omium.org <yunkec@...omium.org>, linux-mediatek@...ts.infradead.org <linux-mediatek@...ts.infradead.org>, linux-media@...r.kernel.org <linux-media@...r.kernel.org>, hdegoede@...hat.com <hdegoede@...hat.com>, bingbu.cao@...el.com <bingbu.cao@...el.com>, paul.elder@...asonboard.com <paul.elder@...asonboard.com>, devicetree@...r.kernel.org <devicetree@...r.kernel.org>, andy.shevchenko@...il.com <andy.shevchenko@...il.com>, Yaya Chang 張雅清 <Yaya.Chang@...iatek.com>, Shengnan Wang 王圣男 <shengnan.wang@...iatek.com>, p.zabel@...gutronix.de <p.zabel@...gutronix.de>, alain.volmat@...s.st.com <alain.volmat@...s.st.com>, sakari.ailus@...ux.intel.com <sakari.ailus@...ux.intel.com>, tomi.valkeinen@...asonboard.com <tomi.valkeinen@...asonboard.com>, 10572168@...com
  <10572168@...com>, hverkuil-cisco@...all.nl <hverkuil-cisco@...all.nl>, linux-arm-kernel@...ts.infradead.org <linux-arm-kernel@...ts.infradead.org>, matthias.bgg@...il.com <matthias.bgg@...il.com>, mehdi.djait@...tlin.com <mehdi.djait@...tlin.com>
Subject: Re: [PATCH v3 2/3] media: i2c: Add GT97xx VCM driver

Hi Zhi,

Also - Cc: Dongchun Zhu <dongchun.zhu@...iatek.com> who is listed as the
DW9768 VCM driver author...

Quoting Zhi Mao (毛智) (2024-06-12 12:13:40)
> Hi Angelo,
> 
> Thanks for your review.
> 
> On Wed, 2024-06-12 at 09:07 +0200, AngeloGioacchino Del Regno wrote:
> > Il 12/06/24 03:20, Zhi Mao ha scritto:
> > > Add a V4L2 sub-device driver for Giantec GT97xx VCM.
> > > 
> > > Signed-off-by: Zhi Mao <zhi.mao@...iatek.com>
> > 
> > Hello Zhi,
> > 
> > I fail to see why would you need to upstream this new driver instead
> > of
> > simply adding the IC_INFO_REG to the already existing (and more
> > featureful)
> > dw9768 driver, which also seems to support the Giantec GT9769 VCM.

Even more so especially as
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/i2c/dw9768.c
already directly supports the compatible strings added by this driver -
surely we don't want multiple (near identical) drivers matching the same
compatible string?

> > 
> 
> Our project uses Giantec VCM hardware. 
> For detailed vendor information, please visit: (
> https://en.giantec-semi.com/yqmd/164). 
> The VCM datasheet we are referencing is provided by Giantec. 
> Currently, the relationship between Giantec VCM and Dongwoon VCM is
> unclear, but Dongwoon seems to be another manufacturer of VCM
> hardware. 
> 
> From the perspective of software driver development and maintenance, it
> makes sense for each vendor's hardware should have its own software
> driver.

Personally, I don't think so. If two vendors make identical parts, we
shouldn't have two identical drivers.

I still have plans to refactor VCM drivers if I get some spare-time(tm)
as almost each driver does the same identical task. They're all just
copies of the boilerplate.  That seems like something we should reduce,
not increase.

--
Kieran


> So, I upstream a new VCM driver for Giantec.
> 
> > Cheers,
> > Angelo