linux-kernel - Re: [PATCH net-next v5 04/12] net: dsa: lantiq_gswip: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240613115137.ignzu35jxmmorxys@skbuf>
Date: Thu, 13 Jun 2024 14:51:37 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Martin Schiller <ms@....tdt.de>
Cc: martin.blumenstingl@...glemail.com, hauke@...ke-m.de, andrew@...n.ch,
	f.fainelli@...il.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 04/12] net: dsa: lantiq_gswip: Use
 dev_err_probe where appropriate

On Tue, Jun 11, 2024 at 03:54:26PM +0200, Martin Schiller wrote:
> From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> 
> dev_err_probe() can be used to simplify the existing code. Also it means
> we get rid of the following warning which is seen whenever the PMAC
> (Ethernet controller which connects to GSWIP's CPU port) has not been
> probed yet:
>   gswip 1e108000.switch: dsa switch register failed: -517
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Acked-by: Hauke Mehrtens <hauke@...ke-m.de>
> ---

Needs your sign off.

Reviewed-by: Vladimir Oltean <olteanv@...il.com>