linux-kernel - Re: [PATCH v2 2/4] KVM: arm64: Add support for FFA_PARTITION_INFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZmrmDHEoZoOXmSd4@google.com>
Date: Thu, 13 Jun 2024 12:29:00 +0000
From: Sebastian Ene <sebastianene@...gle.com>
To: Sudeep Holla <sudeep.holla@....com>
Cc: catalin.marinas@....com, james.morse@....com, jean-philippe@...aro.org,
	maz@...nel.org, oliver.upton@...ux.dev, qperret@...gle.com,
	qwandor@...gle.com, suzuki.poulose@....com, tabba@...gle.com,
	will@...nel.org, yuzenghui@...wei.com, lpieralisi@...nel.org,
	kvmarm@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, kernel-team@...roid.com
Subject: Re: [PATCH v2 2/4] KVM: arm64: Add support for FFA_PARTITION_INFO_GET

On Wed, Jun 12, 2024 at 03:30:29PM +0100, Sudeep Holla wrote:
> On Wed, May 15, 2024 at 05:22:56PM +0000, Sebastian Ene wrote:
> > Handle the FFA_PARTITION_INFO_GET host call inside the pKVM hypervisor
> > and copy the response message back to the host buffers.
> >
> > Save the returned FF-A version as we will need it later to interpret the
> > response from the TEE.
> >
> I don't understand the context of the above statement and this patch.
> Did you mean use the saved version to take apt action/decision within
> FFA_PARTITION_INFO_GET handler. Or is it just missed cleanup ?

This is a missed cleanup I will drop this part from the commit message.

Thanks,
Seb

> 
> The change itself looks good.
> 
> Reviewed-by: Sudeep Holla <sudeep.holla@....com>
> 
> --
> Regards,
> Sudeep