linux-kernel - Re: [PATCH net-next v5 08/12] net: dsa: lantiq_gswip: Change literal 6 to ETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <234a55f08593f7c8d003d87b3ff1aac9@dev.tdt.de>
Date: Thu, 13 Jun 2024 14:35:09 +0200
From: Martin Schiller <ms@....tdt.de>
To: martin.blumenstingl@...glemail.com, hauke@...ke-m.de, andrew@...n.ch,
 f.fainelli@...il.com, olteanv@...il.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 08/12] net: dsa: lantiq_gswip: Change literal
 6 to ETH_ALEN

On 2024-06-11 15:54, Martin Schiller wrote:
> From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> 
> The addr variable in gswip_port_fdb_dump() stores a mac address. Use
> ETH_ALEN to make this consistent across other drivers.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Reviewed-by: Vladimir Oltean <olteanv@...il.com>
> Acked-by: Hauke Mehrtens <hauke@...ke-m.de>
> ---
>  drivers/net/dsa/lantiq_gswip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.c 
> b/drivers/net/dsa/lantiq_gswip.c
> index 58c069f964dd..525a62a21601 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -1413,7 +1413,7 @@ static int gswip_port_fdb_dump(struct dsa_switch
> *ds, int port,
>  {
>  	struct gswip_priv *priv = ds->priv;
>  	struct gswip_pce_table_entry mac_bridge = {0,};
> -	unsigned char addr[6];
> +	unsigned char addr[ETH_ALEN];
>  	int i;
>  	int err;

Signed-off-by: Martin Schiller <ms@....tdt.de>