linux-kernel - Re: [PATCH 1/1] s390/virtio_ccw: fix config change notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 15:21:15 +0200
From: Halil Pasic <pasic@...ux.ibm.com>
To: Thomas Huth <thuth@...hat.com>
Cc: Cornelia Huck <cohuck@...hat.com>, Eric Farman <farman@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger
 <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, linux-s390@...r.kernel.org,
        virtualization@...ts.linux.dev, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Boqiao Fu
 <bfu@...hat.com>,
        Sebastian Mitterle <smitterl@...hat.com>,
        Halil Pasic
 <pasic@...ux.ibm.com>
Subject: Re: [PATCH 1/1] s390/virtio_ccw: fix config change notifications

On Wed, 12 Jun 2024 16:04:15 +0200
Thomas Huth <thuth@...hat.com> wrote:

> On 11/06/2024 23.47, Halil Pasic wrote:
> > Commit e3e9bda38e6d ("s390/virtio_ccw: use DMA handle from DMA API")
> > broke configuration change notifications for virtio-ccw by putting the
> > DMA address of *indicatorp directly into ccw->cda disregarding the fact
> > that if !!(vcdev->is_thinint) then the function
> > virtio_ccw_register_adapter_ind() will overwrite that ccw->cda value
> > with the address of the virtio_thinint_area so it can actually set up
> > the adapter interrupts via CCW_CMD_SET_IND_ADAPTER.  Thus we end up
> > pointing to the wrong object for both CCW_CMD_SET_IND if setting up the
> > adapter interrupts fails, and for CCW_CMD_SET_CONF_IND regardless
> > whether it succeeds or fails.
> > 
> > To fix this, let us save away the dma address of *indicatorp in a local
> > variable, and copy it to ccw->cda after the "vcdev->is_thinint" branch.
> > 
> > Reported-by: Boqiao Fu <bfu@...hat.com>
> > Reported-by: Sebastian Mitterle <smitterl@...hat.com>
> > Fixes: e3e9bda38e6d ("s390/virtio_ccw: use DMA handle from DMA API")
> > Signed-off-by: Halil Pasic <pasic@...ux.ibm.com>
> > ---
> > I know that checkpatch.pl complains about a missing 'Closes' tag.
> > Unfortunately I don't have an appropriate URL at hand. @Sebastian,
> > @Boqiao: do you have any suggetions?  
> 
> Closes: https://issues.redhat.com/browse/RHEL-39983
> ?

Yep! That is a public bug tracker bug. Qualifies!
@Vasily: Can you guys pick hat one up when picking the patch?

> 
> Anyway, I've tested the patch and it indeed fixes the problem with 
> virtio-balloon and the link state for me:
> 
> Tested-by: Thomas Huth <thuth@...hat.com>
> 

Thanks!