linux-kernel - Re: [PATCH v7 1/4] mm/rmap: remove duplicated exit code in pagewalk loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 21:45:49 +0800
From: Lance Yang <ioworker0@...il.com>
To: David Hildenbrand <david@...hat.com>
Cc: Barry Song <21cnbao@...il.com>, akpm@...ux-foundation.org, willy@...radead.org, 
	sj@...nel.org, baolin.wang@...ux.alibaba.com, maskray@...gle.com, 
	ziy@...dia.com, ryan.roberts@....com, mhocko@...e.com, fengwei.yin@...el.com, 
	zokeefe@...gle.com, shy828301@...il.com, xiehuan09@...il.com, 
	libang.li@...group.com, wangkefeng.wang@...wei.com, songmuchun@...edance.com, 
	peterx@...hat.com, minchan@...nel.org, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 1/4] mm/rmap: remove duplicated exit code in pagewalk loop

On Thu, Jun 13, 2024 at 9:29 PM David Hildenbrand <david@...hat.com> wrote:
>
> On 13.06.24 14:43, Lance Yang wrote:
> > On Thu, Jun 13, 2024 at 4:49 PM Lance Yang <ioworker0@...il.com> wrote:
> >>
> >> On Thu, Jun 13, 2024 at 4:27 PM David Hildenbrand <david@...hat.com> wrote:
> >>>
> >>> On 13.06.24 09:52, Barry Song wrote:
> >>>> On Tue, Jun 11, 2024 at 12:02 AM Lance Yang <ioworker0@...il.com> wrote:
> >>>>>
> >>>>> Introduce the labels walk_done and walk_done_err as exit points to
> >>>>> eliminate duplicated exit code in the pagewalk loop.
> >>>>>
> >>>>> Reviewed-by: Zi Yan <ziy@...dia.com>
> >>>>> Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> >>>>> Reviewed-by: David Hildenbrand <david@...hat.com>
> >>>>> Signed-off-by: Lance Yang <ioworker0@...il.com>
> >>>>
> >>
> >> Hi Barry and David,
> >>
> >> Thanks for taking time to review!
> >>
> >>>> I don't think "return false" necessarily indicates an error, so
> >>>> "walk_done_err" doesn't seem like an appropriate name.
> >>>> However, this is a minor issue.
> >>>
> >>> Agreed. As we only have a single walk_done user, should we instead
> >>> remove "walk_done", keep the "page_vma_mapped_walk_done" for that single
> >>> user, and rename "walk_done_err" to "abort_walk" ?
> >>
> >> Yeah, I agree that 'abort_walk' is better than 'walk_done_err', and let's
> >> keep 'page_vma_mapped_walk_done' for that single user ;)
> >
> > I just realized that there is another walk_done user, which is
> > unmap_huge_pmd_locked().
> >
> > Could I keep "walk_done" but rename it to "done_walk"?
>
> Sure. "walk_done"/"walk_abort" might sound better.

Nice. Thanks for the suggestion!

Lance

>
> --
> Cheers,
>
> David / dhildenb
>