linux-kernel - Re: [PATCH v8] ALSA: hda/tas2781: Add tas2781 hda SPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6428e19-986d-4451-bfcf-17705cc9e53b@wanadoo.fr>
Date: Fri, 14 Jun 2024 17:41:30 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Baojun Xu <baojun.xu@...com>, tiwai@...e.de
Cc: robh+dt@...nel.org, andriy.shevchenko@...ux.intel.com,
 lgirdwood@...il.com, perex@...ex.cz, pierre-louis.bossart@...ux.intel.com,
 kevin-lu@...com, shenghao-ding@...com, navada@...com, 13916275206@....com,
 v-hampiholi@...com, v-po@...com, niranjan.hy@...com,
 alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
 liam.r.girdwood@...el.com, yung-chuan.liao@...ux.intel.com,
 broonie@...nel.org, soyer@....hu
Subject: Re: [PATCH v8] ALSA: hda/tas2781: Add tas2781 hda SPI driver

Le 14/06/2024 à 06:05, Baojun Xu a écrit :
> This patch was used to add TAS2781 devices on SPI support in sound/pci/hda.
> It use ACPI node descript about parameters of TAS2781 on SPI, it like:
>      Scope (_SB.PC00.SPI0)
>      {
>          Device (GSPK)
>          {
>              Name (_HID, "TXNW2781")  // _HID: Hardware ID
>              Method (_CRS, 0, NotSerialized)
>              {
>                  Name (RBUF, ResourceTemplate ()
>                  {
>                      SpiSerialBusV2 (...)
>                      SpiSerialBusV2 (...)
>                  }
>              }
>          }
>      }
> 
> And in platform/x86/serial-multi-instantiate.c, those spi devices will be
> added into system as a single SPI device, so TAS2781 SPI driver will
> probe twice for every single SPI device. And driver will also parser
> mono DSP firmware binary and RCA binary for itself.
> The code support Realtek as the primary codec.
> 
> Signed-off-by: Baojun Xu <baojun.xu@...com>
> 
> ---

Hi,

not a must-have but using "checkpatch.pl --strict" could slightly 
improve readability in some places.

Maybe at least,
    - ./scripts/checkpatch.pl --strict --test-only=Blank
      --> to save a few LoC

    - ./scripts/checkpatch.pl --strict --test-only=parentheses
      --> to improve readability and reduce the length of some lines


This is already v8, so feel free to just ignore this mail and the 
--strict option.

CJ