[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240614161632.GA1116318@bhelgaas>
Date: Fri, 14 Jun 2024 11:16:32 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Philipp Stanner <pstanner@...hat.com>
Cc: Hans de Goede <hdegoede@...hat.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Sam Ravnborg <sam@...nborg.org>, dakr@...hat.com,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
linux-pci@...r.kernel.org
Subject: Re: [PATCH v9 00/13] Make PCI's devres API more consistent
On Fri, Jun 14, 2024 at 01:38:41PM +0200, Philipp Stanner wrote:
> On Thu, 2024-06-13 at 16:57 -0500, Bjorn Helgaas wrote:
> > This is on pci/devres with some commit log rework and the following
> > diffs. I think the bar short/int thing is the only actual code
> > change. Happy to squash in any other updates or things I botched.
>
> I looked through your tree and only found the following nit:
>
> In commit "PCI: Remove struct pci_devres.enabled status bit" you
> changed the line
>
> "The PCI devres implementation has a separate boolean to track whether
> a"
>
> to:
>
> "The pci_devres struct has a separate boolean to track whether a device
> is"
>
> In past reviews that has been criticized and I was told to always call
> it "struct pci_devres", not the other way around. That's also how it's
> put in the following paragraph.
Amended to that, thanks.
Powered by blists - more mailing lists