linux-kernel - Re: [PATCH 3/3] block: BFQ: Refactor bfq_exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b628c844-1e3a-4c5f-9636-dad570a70517@acm.org>
Date: Fri, 14 Jun 2024 09:37:54 -0700
From: Bart Van Assche <bvanassche@....org>
To: John Garry <john.g.garry@...cle.com>, axboe@...nel.dk,
 paolo.valente@...more.it
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 jiapeng.chong@...ux.alibaba.com, hch@....de
Subject: Re: [PATCH 3/3] block: BFQ: Refactor bfq_exit_icq() to silence sparse
 warning

On 6/14/24 2:03 AM, John Garry wrote:
> Currently building for C=1 generates the following warning:
> block/bfq-iosched.c:5498:9: warning: context imbalance in 'bfq_exit_icq' - different lock contexts for basic block
> 
> Refactor bfq_exit_icq() into a core part which loops for the actuators,
> and only lock calling this routine when necessary.

I like this patch because it makes the code easier to read.

Reviewed-by: Bart Van Assche <bvanassche@....org>