[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202406150041.QTui5Xgq-lkp@intel.com>
Date: Sat, 15 Jun 2024 00:55:53 +0800
From: kernel test robot <lkp@...el.com>
To: "Jason-JH.Lin" <jason-jh.lin@...iatek.com>,
Jassi Brar <jassisinghbrar@...il.com>,
Chun-Kuang Hu <chunkuang.hu@...nel.org>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: oe-kbuild-all@...ts.linux.dev,
Matthias Brugger <matthias.bgg@...il.com>,
"Jason-JH . Lin" <jason-jh.lin@...iatek.com>,
Singo Chang <singo.chang@...iatek.com>,
Nancy Lin <nancy.lin@...iatek.com>, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org,
Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH 1/2] mailbox: Add power_get/power_put API to mbox_chan_ops
Hi Jason-JH.Lin,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on fujitsu-integration/mailbox-for-next v6.10-rc3 next-20240613]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jason-JH-Lin/mailbox-Add-power_get-power_put-API-to-mbox_chan_ops/20240614-120412
base: linus/master
patch link: https://lore.kernel.org/r/20240614040133.24967-2-jason-jh.lin%40mediatek.com
patch subject: [PATCH 1/2] mailbox: Add power_get/power_put API to mbox_chan_ops
config: arc-randconfig-002-20240614 (https://download.01.org/0day-ci/archive/20240615/202406150041.QTui5Xgq-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240615/202406150041.QTui5Xgq-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406150041.QTui5Xgq-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/mailbox/mailbox.c: In function '__mbox_bind_client':
>> drivers/mailbox/mailbox.c:382:32: warning: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion]
382 | return ERR_PTR(ret);
| ^~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for REGMAP_SPI
Depends on [n]: SPI [=n]
Selected by [y]:
- AD9739A [=y] && IIO [=y] && (SPI [=n] || COMPILE_TEST [=y])
vim +382 drivers/mailbox/mailbox.c
355
356 static int __mbox_bind_client(struct mbox_chan *chan, struct mbox_client *cl)
357 {
358 struct device *dev = cl->dev;
359 unsigned long flags;
360 int ret;
361
362 if (chan->cl || !try_module_get(chan->mbox->dev->driver->owner)) {
363 dev_dbg(dev, "%s: mailbox not free\n", __func__);
364 return -EBUSY;
365 }
366
367 spin_lock_irqsave(&chan->lock, flags);
368 chan->msg_free = 0;
369 chan->msg_count = 0;
370 chan->active_req = NULL;
371 chan->cl = cl;
372 init_completion(&chan->tx_complete);
373
374 if (chan->txdone_method == TXDONE_BY_POLL && cl->knows_txdone)
375 chan->txdone_method = TXDONE_BY_ACK;
376
377 spin_unlock_irqrestore(&chan->lock, flags);
378
379 if (chan->mbox->ops->power_get) {
380 ret = chan->mbox->ops->power_get(chan);
381 if (ret < 0)
> 382 return ERR_PTR(ret);
383 }
384
385 if (chan->mbox->ops->startup) {
386 ret = chan->mbox->ops->startup(chan);
387
388 if (ret) {
389 dev_err(dev, "Unable to startup the chan (%d)\n", ret);
390 mbox_free_channel(chan);
391 return ret;
392 }
393 }
394
395 return 0;
396 }
397
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists