linux-kernel - Re: [PATCH] drm/ci: mark kms_addfb_basic@...fb25-bad-modifier as passing on msm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af6d496e-2f49-4f12-bc12-426e06d24494@collabora.com>
Date: Fri, 14 Jun 2024 14:03:48 -0300
From: Helen Koike <helen.koike@...labora.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Abhinav Kumar <quic_abhinavk@...cinc.com>
Cc: Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/ci: mark kms_addfb_basic@...fb25-bad-modifier as
 passing on msm



On 13/06/2024 14:55, Dmitry Baryshkov wrote:
> On Thu, 13 Jun 2024 at 20:49, Abhinav Kumar <quic_abhinavk@...cinc.com> wrote:
>>
>>
>>
>> On 6/13/2024 9:33 AM, Dmitry Baryshkov wrote:
>>> The commit b228501ff183 ("drm/msm: merge dpu format database to MDP
>>> formats") made get_format take modifiers into account. This makes
>>> kms_addfb_basic@...fb25-bad-modifier pass on MDP4 and MDP5 platforms.
>>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>> ---
>>>    drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 1 -
>>>    drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt | 1 -
>>>    2 files changed, 2 deletions(-)
>>>
>>
>> Would be good to also give a link to the CI for the CI maintainers.
>>
>> But otherwise, LGTM
>>
>> Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>
> 
> Yes, good idea: https://gitlab.freedesktop.org/drm/msm/-/merge_requests/119


Nice to see new tests passing!

Acked-by: Helen Koike <helen.koike@...labora.com>

I'm applying it to drm-misc-next

Thanks,
Helen

> 
>>
>>
>>> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> index 3dfbabdf905e..6e7fd1ccd1e3 100644
>>> --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> @@ -4,7 +4,6 @@ device_reset@...ind-cold-reset-rebind,Fail
>>>    device_reset@...ind-reset-rebind,Fail
>>>    dumb_buffer@...alid-bpp,Fail
>>>    kms_3d,Fail
>>> -kms_addfb_basic@...fb25-bad-modifier,Fail
>>>    kms_cursor_legacy@...ked-move,Fail
>>>    kms_cursor_legacy@...gle-bo,Fail
>>>    kms_cursor_legacy@...ture-bo,Fail
>>> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt b/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt
>>> index 23a5f6f9097f..46ca69ce2ffe 100644
>>> --- a/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt
>>> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt
>>> @@ -4,6 +4,5 @@ device_reset@...ind-cold-reset-rebind,Fail
>>>    device_reset@...ind-reset-rebind,Fail
>>>    dumb_buffer@...alid-bpp,Fail
>>>    kms_3d,Fail
>>> -kms_addfb_basic@...fb25-bad-modifier,Fail
>>>    kms_lease@...se-uevent,Fail
>>>    tools_test@...ls_test,Fail
>>>
>>> ---
>>> base-commit: 6b4468b0c6ba37a16795da567b58dc80bc7fb439
>>> change-id: 20240613-msm-pass-addfb25-bad-modifier-c461fd9c02bb
>>>
>>> Best regards,
> 
> 
>