linux-kernel - Re: [PATCH net-next 2/3] net: phy: dp83867: add cable test support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21b38798-46e2-4a26-bf8c-554524fdcdc4@lunn.ch>
Date: Fri, 14 Jun 2024 20:16:32 +0200
From: Andrew Lunn <andrew@...n.ch>
To: João Rodrigues <jrodrigues@...met.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"open list:ETHERNET PHY LIBRARY" <netdev@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 2/3] net: phy: dp83867: add cable test support

On Fri, Jun 14, 2024 at 06:52:10PM +0200, João Rodrigues wrote:
> On Thu, 13 Jun 2024 19:19:45 +0200
> Andrew Lunn <andrew@...n.ch> wrote:
> 
> > > +/* TDR bits */
> > > +#define DP83867_TDR_GEN_CFG5_FLAGS	0x294A
> > > +#define DP83867_TDR_GEN_CFG6_FLAGS	0x0A9B  
> > 
> > Is it documented what these bits actually mean?
> > 
> >    Andrew
> 
> No, all three (CFG5, CFG6 and CFG7) are undocumented.

Then i would suggest you use the magic values directly.  The only
advantage i see with DP83867_TDR_GEN_CFG5_FLAGS is that is stops you
accidentally using it with CFG4, etc. But magic is magic, and you
should not really hide it.

       Andrew