linux-kernel - Re: [PATCH v6 5/8] drm/i915: Enable async flips on the primary plane

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZmyTYPTVKM2-iaaN@intel.com>
Date: Fri, 14 Jun 2024 15:00:48 -0400
From: Rodrigo Vivi <rodrigo.vivi@...el.com>
To: André Almeida <andrealmeid@...lia.com>, Ville
 Syrjälä <ville.syrjala@...el.com>,
	<naveen1.kumar@...el.com>, <vandita.kulkarni@...el.com>
CC: <dri-devel@...ts.freedesktop.org>, <amd-gfx@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<nouveau@...ts.freedesktop.org>, <intel-gfx@...ts.freedesktop.org>,
	<kernel-dev@...lia.com>, Melissa Wen <mwen@...lia.com>,
	<alexander.deucher@....com>, <christian.koenig@....com>, Simon Ser
	<contact@...rsion.fr>, Pekka Paalanen <ppaalanen@...il.com>,
	<daniel@...ll.ch>, Daniel Stone <daniel@...ishbar.org>, 'Marek
 Olšák' <maraeo@...il.com>, Dave Airlie <airlied@...il.com>,
	<ville.syrjala@...ux.intel.com>, Xaver Hugl <xaver.hugl@...il.com>, "Joshua
 Ashton" <joshua@...ggi.es>, Michel Dänzer
	<michel.daenzer@...lbox.org>, Sam Ravnborg <sam@...nborg.org>, "Boris
 Brezillon" <bbrezillon@...nel.org>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, Nicolas Ferre
	<nicolas.ferre@...rochip.com>, Alexandre Belloni
	<alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
	Jani Nikula <jani.nikula@...ux.intel.com>, Karol Herbst <kherbst@...hat.com>,
	Lyude Paul <lyude@...hat.com>
Subject: Re: [PATCH v6 5/8] drm/i915: Enable async flips on the primary plane

On Fri, Jun 14, 2024 at 12:35:32PM -0300, André Almeida wrote:
> This driver can perfom async flips on primary planes, so enable it.
> 

Cc: Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc: Naveen Kumar <naveen1.kumar@...el.com>
c: Vandita Kulkarni <vandita.kulkarni@...el.com>

> Signed-off-by: André Almeida <andrealmeid@...lia.com>
> ---
>  drivers/gpu/drm/i915/display/i9xx_plane.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c
> index 0279c8aabdd1..0142beef20dc 100644
> --- a/drivers/gpu/drm/i915/display/i9xx_plane.c
> +++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
> @@ -931,6 +931,9 @@ intel_primary_plane_create(struct drm_i915_private *dev_priv, enum pipe pipe)
>  
>  	intel_plane_helper_add(plane);
>  
> +	if (plane->async_flip)
> +		plane->base.async_flip = true;

I believe this is not enough and besides this we would also need to have
in the:
skl_universal_plane_create[2447] plane->async_flip = skl_plane_async_flip;

at: drivers/gpu/drm/i915/display/skl_universal_plane.c

> +
>  	return plane;
>  
>  fail:
> -- 
> 2.45.2
>