linux-kernel - RE: [PATCH V4 for-6.10/block] loop: Fix a race between loop detach and loop open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <IA1PR10MB724052E773F52C756F4F295F98C22@IA1PR10MB7240.namprd10.prod.outlook.com>
Date: Fri, 14 Jun 2024 23:35:20 +0000
From: Gulam Mohamed <gulam.mohamed@...cle.com>
To: "hch@....de" <hch@....de>
CC: kernel test robot <oliver.sang@...el.com>,
        "oe-lkp@...ts.linux.dev"
	<oe-lkp@...ts.linux.dev>,
        "lkp@...el.com" <lkp@...el.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "ltp@...ts.linux.it" <ltp@...ts.linux.it>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "yukuai1@...weicloud.com"
	<yukuai1@...weicloud.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>
Subject: RE: [PATCH V4 for-6.10/block] loop: Fix a race between loop detach
 and loop open

Hi Christoph,

> -----Original Message-----
> From: hch@....de <hch@....de>
> Sent: Friday, June 14, 2024 11:16 AM
> To: Gulam Mohamed <gulam.mohamed@...cle.com>
> Cc: kernel test robot <oliver.sang@...el.com>; oe-lkp@...ts.linux.dev;
> lkp@...el.com; linux-block@...r.kernel.org; ltp@...ts.linux.it; linux-
> kernel@...r.kernel.org; yukuai1@...weicloud.com; hch@....de;
> axboe@...nel.dk
> Subject: Re: [PATCH V4 for-6.10/block] loop: Fix a race between loop detach
> and loop open
> 
> On Thu, Jun 13, 2024 at 09:10:37PM +0000, Gulam Mohamed wrote:
> > I looked at the LTP test case failure and also the function
> tst_detach_device_by_fd() which failed. Our kernel patch will defer all the
> attempts to detach a loop device to the last close, to fix an issue.
> > The tst_detach_device_by_fd() in LTP test case will open the loop device
> and repeatedly checks for error code ENXIO. As the new approach, as I
> mentioned above, will defer the detach to last close and the last close
> happens *only* when the LTP test function tst_detach_device_by_fd()
> returns, the test will obviously fail. So, Can you please modify the LTP test case
> to accommodate the new behaviour of kernel code for loop detach?
> > Please let us know your comments.
> 
> I still think simply setting the rundown state is the better approach..

Thanks for the review Christoph. I am sending the V5 as you suggested.

Regards,
Gulam Mohamed.