| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CYYPR12MB86557B1F2686ED2B4DA136269CC22@CYYPR12MB8655.namprd12.prod.outlook.com> Date: Fri, 14 Jun 2024 03:18:37 +0000 From: "Yuan, Perry" <Perry.Yuan@....com> To: "Limonciello, Mario" <Mario.Limonciello@....com> CC: "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>, "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>, "Deucher, Alexander" <Alexander.Deucher@....com>, "Huang, Shimmer" <Shimmer.Huang@....com>, "Du, Xiaojian" <Xiaojian.Du@....com>, "Meng, Li (Jassmine)" <Li.Meng@....com>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Petkov, Borislav" <Borislav.Petkov@....com>, "Shenoy, Gautham Ranjal" <gautham.shenoy@....com> Subject: RE: [PATCH v11 0/9] AMD Pstate Driver Core Performance Boost [AMD Official Use Only - AMD Internal Distribution Only] > -----Original Message----- > From: Limonciello, Mario <Mario.Limonciello@....com> > Sent: Friday, June 14, 2024 1:54 AM > To: Yuan, Perry <Perry.Yuan@....com>; Shenoy, Gautham Ranjal > <gautham.shenoy@....com>; Petkov, Borislav <Borislav.Petkov@....com> > Cc: rafael.j.wysocki@...el.com; viresh.kumar@...aro.org; Deucher, Alexander > <Alexander.Deucher@....com>; Huang, Shimmer > <Shimmer.Huang@....com>; Du, Xiaojian <Xiaojian.Du@....com>; Meng, > Li (Jassmine) <Li.Meng@....com>; linux-pm@...r.kernel.org; linux- > kernel@...r.kernel.org > Subject: Re: [PATCH v11 0/9] AMD Pstate Driver Core Performance Boost > > This is the cover letter, so if no other feedback no need to fix up. But if you > need a v12 then typos below. Thank you Mario, will get this done in v12. > > On 6/13/2024 02:25, Perry Yuan wrote: > > Hi all, > > The patchset series implement CPB(core performance boost) feature for > > AMD pstate driver including passisve ,guide and active mode support. > > passive > guided > > > > > User can change global core frequency boost control with a new sysfs > entry: > > > > "/sys/devices/system/cpu/amd_pstate/cpb_boost" > > > > Now it also support to update indivial CPU boost state in sysfs boost file. > > individual > > > "/sys/devices/system/cpu/cpuX/cpufreq/boost" > > > > And global control will override the indivial CPU boost state by default. > > individual > > > > > 1) globally disable core boost: > > $ sudo bash -c "echo 0 > /sys/devices/system/cpu/amd_pstate/cpb_boost" > > $ lscpu -ae > > CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ > MHZ > > 0 0 0 0 0:0:0:0 yes 4201.0000 400.0000 2983.578 > > 1 0 0 1 1:1:1:0 yes 4201.0000 400.0000 2983.578 > > 2 0 0 2 2:2:2:0 yes 4201.0000 400.0000 2583.855 > > 3 0 0 3 3:3:3:0 yes 4201.0000 400.0000 2983.578 > > 4 0 0 4 4:4:4:0 yes 4201.0000 400.0000 2983.578 > > > > 2) globally enable core boost: > > $ sudo bash -c "echo 1 > /sys/devices/system/cpu/amd_pstate/cpb_boost" > > $ lscpu -ae > > 0 0 0 0 0:0:0:0 yes 5759.0000 400.0000 2983.578 > > 1 0 0 1 1:1:1:0 yes 5759.0000 400.0000 2983.578 > > 2 0 0 2 2:2:2:0 yes 5759.0000 400.0000 2983.578 > > 3 0 0 3 3:3:3:0 yes 5759.0000 400.0000 2983.578 > > 4 0 0 4 4:4:4:0 yes 5759.0000 400.0000 2983.578 > > > > > > > =============================================================== > ======= > > ====== The V9 patches add per CPU boost control, user can > > enable/disable CPUs boost as the below command tested on a laptop > > system. > > # before > > CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ > MHZ > > 0 0 0 0 0:0:0:0 yes 4208.0000 400.0000 1666.7740 > > 1 0 0 0 0:0:0:0 yes 4208.0000 400.0000 400.0000 > > 2 0 0 1 1:1:1:0 yes 4208.0000 400.0000 3386.1260 > > 3 0 0 1 1:1:1:0 yes 4208.0000 400.0000 400.0000 > > $ sudo rdmsr 0xc00102b3 -p 0 > > 10a6 > > > > $ sudo bash -c "echo 1 > /sys/devices/system/cpu/cpu0/cpufreq/boost" > > # after > > CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ > MHZ > > 0 0 0 0 0:0:0:0 yes 3501.0000 400.0000 400.0000 > > 1 0 0 0 0:0:0:0 yes 4208.0000 400.0000 1391.0690 > > 2 0 0 1 1:1:1:0 yes 4208.0000 400.0000 3654.4541 > > 3 0 0 1 1:1:1:0 yes 4208.0000 400.0000 400.0000 > > $ sudo rdmsr 0xc00102b3 -p 0 > > 108a > > > > rebasd to keep syncing to Mario kernel tree: bleeding-edge > > https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git > > > > Tested result: > > > > CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ > MHZ > > 0 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140 > > 1 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140 > > 2 0 0 1 1:1:1:0 yes 4354.0000 400.0000 1110.7140 > > 3 0 0 1 1:1:1:0 yes 4354.0000 400.0000 3110.0000 > > 4 0 0 2 2:2:2:0 yes 4354.0000 400.0000 2732.3569 > > 5 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140 > > 6 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140 > > 7 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140 > > 8 0 0 4 4:4:4:0 yes 4354.0000 400.0000 2312.2109 > > 9 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140 > > 10 0 0 5 5:5:5:0 yes 4354.0000 400.0000 2310.1011 > > 11 0 0 5 5:5:5:0 yes 4354.0000 400.0000 1110.7140 > > > > sudo bash -c "echo 0 > /sys/devices/system/cpu/cpu11/cpufreq/boost" > > sudo bash -c "echo 0 > /sys/devices/system/cpu/cpu10/cpufreq/boost" > > sudo bash -c "echo 0 > /sys/devices/system/cpu/cpu9/cpufreq/boost" > > > > CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ > MHZ > > 0 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1242.7240 > > 1 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140 > > 2 0 0 1 1:1:1:0 yes 4354.0000 400.0000 2754.5710 > > 3 0 0 1 1:1:1:0 yes 4354.0000 400.0000 2659.8159 > > 4 0 0 2 2:2:2:0 yes 4354.0000 400.0000 2308.9929 > > 5 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140 > > 6 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140 > > 7 0 0 3 3:3:3:0 yes 4354.0000 400.0000 1110.7140 > > 8 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140 > > 9 0 0 4 4:4:4:0 yes 2801.0000 400.0000 1110.7140 > > 10 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1110.7140 > > 11 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1110.7140 > > > > sudo bash -c "echo 0 > /sys/devices/system/cpu/amd_pstate/cpb_boost" > > > > CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ > MHZ > > 0 0 0 0 0:0:0:0 yes 2801.0000 400.0000 1233.8630 > > 1 0 0 0 0:0:0:0 yes 2801.0000 400.0000 1110.7140 > > 2 0 0 1 1:1:1:0 yes 2801.0000 400.0000 2714.4851 > > 3 0 0 1 1:1:1:0 yes 2801.0000 400.0000 2732.3569 > > 4 0 0 2 2:2:2:0 yes 2801.0000 400.0000 2564.2639 > > 5 0 0 2 2:2:2:0 yes 2801.0000 400.0000 1110.7140 > > 6 0 0 3 3:3:3:0 yes 2801.0000 400.0000 2732.3569 > > 7 0 0 3 3:3:3:0 yes 2801.0000 400.0000 1110.7140 > > 8 0 0 4 4:4:4:0 yes 2801.0000 400.0000 1233.8660 > > 9 0 0 4 4:4:4:0 yes 2801.0000 400.0000 1110.7140 > > 10 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1233.6630 > > 11 0 0 5 5:5:5:0 yes 2801.0000 400.0000 1233.5050 > > > > sudo bash -c "echo 1 > /sys/devices/system/cpu/amd_pstate/cpb_boost" > > > > CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE MAXMHZ MINMHZ > MHZ > > 0 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1234.0200 > > 1 0 0 0 0:0:0:0 yes 4354.0000 400.0000 1110.7140 > > 2 0 0 1 1:1:1:0 yes 4354.0000 400.0000 1110.7140 > > 3 0 0 1 1:1:1:0 yes 4354.0000 400.0000 1110.7140 > > 4 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140 > > 5 0 0 2 2:2:2:0 yes 4354.0000 400.0000 1110.7140 > > 6 0 0 3 3:3:3:0 yes 4354.0000 400.0000 2278.8491 > > 7 0 0 3 3:3:3:0 yes 4354.0000 400.0000 2732.3569 > > 8 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140 > > 9 0 0 4 4:4:4:0 yes 4354.0000 400.0000 1110.7140 > > 10 0 0 5 5:5:5:0 yes 4354.0000 400.0000 2353.0449 > > 11 0 0 5 5:5:5:0 yes 4354.0000 400.0000 1110.7140 > > > > > > Perry. > > > > Changes from v10: > > * rework the boost interface with cpufreq core boost control, align the > sysfs file > > created from cpufreq.c and allow indivial CPU boost control (Mario) > > * fix the pr_warn code format with %zd (Oleksandr Natalenko) > > * replace sscanf with kstrtobool for cpufreq.c (new) > > * drop the boost sysfs file creation from amd pstate patch #6 > > * add init_boost for cpufreq.c to unify the boost file creation(Mario) > > * add set_boost callback for EPP driver mode > > * fix syncronization issue for indivial boost control and global CPB control, > now the > > two control way will keep syncronization after anyone CPU boost state > changed. > > * rebased to Mario kernel tree: bleeding-edge > > * run testing on local system, no regression issue found so far. > > > > Changes from v9: > > * change per CPU boost sysfs file name to `boost` (Mario) > > * rebased to latest linux-pm/bleeding-edge > > > > Changes from v8: > > * pick RB flag for patch 4 (Mario) > > * change boot_cpu_has to cpu_feature_enabled for patch 2 (Boris) > > * merge patch 6 into patch 3 (Mario) > > * add two patch for per CPU boost control patch 6 & 7(Mario) > > * rebased to latest linux-pm/bleeding-edge > > > > Changes from v7: > > * fix the mutext locking issue in the sysfs file update(Ray, Mario) > > * pick ack flag from Ray > > * use X86_FEATURE_CPB to verify the CPB function in Patch #2(Ray) > > * rerun the testing to check function works well > > * rebased to linux-pm/bleeding-edge latest > > > > Changes from v6: > > * reword patch 2 commit log (Gautham) > > * update cover letter description(Gautham) > > * rebase to kernel v6.9-rc5 > > > > Changes from v4: > > * drop the legacy boost remove patch, let us keep the legacy interface > > in case some applications break. > > * rebase to linux-pm/bleeding-edge branch > > * rework the patchset base on [PATCH v8 0/8] AMD Pstate Fixes And > > Enhancements which has some intial work done there. > > > > Changes from v4: > > * move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h > > * pick RB flag from Gautham R. Shenoy > > * add Cc Oleksandr Natalenko <oleksandr@...alenko.name> > > * rebase to latest linux-pm/bleeding-edge branch > > * rebase the patch set on top of [PATCH v7 0/6] AMD Pstate Fixes And > Enhancements > > * update [PATCH v7 2/6] to use MSR_K7_HWCR_CPB_DIS_BIT > > > > Changes from v3: > > * rebased to linux-pm/bleeding-edge v6.8 > > * rename global to amd_pstate_global_params(Oleksandr Natalenko) > > * remove comments for boot_supported in amd_pstate.h > > * fix the compiler warning for amd-pstate-ut.ko > > * use for_each_online_cpu in cpb_boost_store which fix the null pointer > > error during testing > > * fix the max frequency value to be KHz when cpb boost > > disabled(Gautham R. Shenoy) > > > > Changes from v2: > > * move global struct to amd-pstate.h > > * fix the amd-pstate-ut with new cpb control interface > > > > Changes from v1: > > * drop suspend/resume fix patch 6/7 because of the fix should be in > > another fix series instead of CPB feature > > * move the set_boost remove patch to the last(Mario) > > * Fix commit info with "Closes:" (Mario) > > * simplified global.cpb_supported initialization(Mario) > > * Add guide mode support for CPB control > > * Fixed some Doc typos and add guide mode info to Doc as well. > > > > v1: > > https://lore.kernel.org/all/cover.1706255676.git.perry.yuan@amd.com/ > > v2: > > https://lore.kernel.org/lkml/cover.1707047943.git.perry.yuan@amd.com/ > > v3: > > https://lore.kernel.org/lkml/cover.1707297581.git.perry.yuan@amd.com/ > > v4: > > https://lore.kernel.org/lkml/cover.1710322310.git.perry.yuan@amd.com/ > > v5: > > https://lore.kernel.org/lkml/cover.1710473712.git.perry.yuan@amd.com/ > > v6: > > https://lore.kernel.org/lkml/cover.1710754236.git.perry.yuan@amd.com/ > > v7: > > https://lore.kernel.org/lkml/cover.1713861200.git.perry.yuan@amd.com/ > > v8: > > https://lore.kernel.org/lkml/cover.1714112854.git.perry.yuan@amd.com/ > > v9: > > https://lore.kernel.org/lkml/cover.1714989803.git.perry.yuan@amd.com/ > > v10: > > https://lore.kernel.org/lkml/cover.1715152592.git.perry.yuan@amd.com/ > > > > Perry Yuan (9): > > cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h > > cpufreq: simplify boolean parsing with kstrtobool in store function > > cpufreq: introduce init_boost callback to initialize boost state for > > pstate drivers > > cpufreq: amd-pstate: initialize new core precision boost state > > cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control > > cpufreq: amd-pstate: Add set_boost callback for active mode > > cpufreq: amd-pstate: fix the MSR highest perf will be reset issue > > while cpb boost off > > Documentation: cpufreq: amd-pstate: introduce the new cpu boost > > control method > > Documentation: cpufreq: amd-pstate: update doc for Per CPU boost > > control method > > > > Documentation/admin-guide/pm/amd-pstate.rst | 30 +++ > > arch/x86/include/asm/msr-index.h | 2 + > > drivers/cpufreq/acpi-cpufreq.c | 2 - > > drivers/cpufreq/amd-pstate-ut.c | 2 +- > > drivers/cpufreq/amd-pstate.c | 197 +++++++++++++++++--- > > drivers/cpufreq/amd-pstate.h | 14 ++ > > drivers/cpufreq/cpufreq.c | 23 ++- > > include/linux/cpufreq.h | 2 + > > 8 files changed, 237 insertions(+), 35 deletions(-) > >
Powered by blists - more mailing lists