linux-kernel - Re: [PATCH v2] mm: shmem: fix getting incorrect lruvec when replacing a shmem folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zmu3YVFfUA6_uToA@casper.infradead.org>
Date: Fri, 14 Jun 2024 04:22:09 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Baolin Wang <baolin.wang@...ux.alibaba.com>
Cc: akpm@...ux-foundation.org, hughd@...gle.com, mhocko@...nel.org,
	roman.gushchin@...ux.dev, shakeel.butt@...ux.dev,
	muchun.song@...ux.dev, hannes@...xchg.org, nphamcs@...il.com,
	yosryahmed@...gle.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm: shmem: fix getting incorrect lruvec when
 replacing a shmem folio

On Fri, Jun 14, 2024 at 08:49:13AM +0800, Baolin Wang wrote:
>   * Charge @new as a replacement folio for @old. @old will
> - * be uncharged upon free. This is only used by the page cache
> - * (in replace_page_cache_folio()).
> + * be uncharged upon free. This is used by the page cache
> + * and shmem (in replace_page_cache_folio() and
> + * shmem_replace_folio()).

Please just delete this sentence.  Functions do not keep track of who
their callers are.