linux-kernel - Re: [PATCH v3 1/8] arm64/sysreg: Add definitions for immediate versions of MSR ALLINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 14 Jun 2024 12:00:32 +0800
From: "Liao, Chang" <liaochang1@...wei.com>
To: Mark Brown <broonie@...nel.org>
CC: Mark Rutland <mark.rutland@....com>, <catalin.marinas@....com>,
	<will@...nel.org>, <maz@...nel.org>, <oliver.upton@...ux.dev>,
	<james.morse@....com>, <suzuki.poulose@....com>, <yuzenghui@...wei.com>,
	<tglx@...utronix.de>, <ardb@...nel.org>, <anshuman.khandual@....com>,
	<miguel.luis@...cle.com>, <joey.gouly@....com>, <ryan.roberts@....com>,
	<jeremy.linton@....com>, <ericchancf@...gle.com>,
	<kristina.martsenko@....com>, <robh@...nel.org>,
	<scott@...amperecomputing.com>, <songshuaishuai@...ylab.org>,
	<shijie@...amperecomputing.com>, <akpm@...ux-foundation.org>,
	<bhe@...hat.com>, <horms@...nel.org>, <mhiramat@...nel.org>,
	<rmk+kernel@...linux.org.uk>, <shahuang@...hat.com>,
	<takakura@...inux.co.jp>, <dianders@...omium.org>, <swboyd@...omium.org>,
	<sumit.garg@...aro.org>, <frederic@...nel.org>, <reijiw@...gle.com>,
	<akihiko.odaki@...nix.com>, <ruanjinjie@...wei.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<kvmarm@...ts.linux.dev>
Subject: Re: [PATCH v3 1/8] arm64/sysreg: Add definitions for immediate
 versions of MSR ALLINT

Hi, Mark

在 2024/6/5 17:52, Liao, Chang 写道:
> Hi, Mark
> 
> 在 2024/6/4 21:29, Mark Brown 写道:
>> On Mon, Jun 03, 2024 at 11:26:39AM +0800, Liao, Chang wrote:
>>
>>> Mark, Is your concern is that the series of pstate related macro name in
>>> sysregs.h are lack of self-explanatory nature, which make it diffuclt to
>>> understand their functionality and purpose? If so, I daft some alternative
>>> macro names in the code below, looking forward to your feedback, or if you
>>> have any proposal for making these helpers discoverable.
>>
>> ...
>>
>>> -#define SET_PSTATE(x, r)               __emit_inst(0xd500401f | PSTATE_ ## r | ((!!x) << PSTATE_Imm_shift))
>>> +#define MSR_PSTATE_ENCODE(x, r)                __emit_inst(0xd500401f | PSTATE_ ## r | ((!!x) << PSTATE_Imm_shift))
>>
>> Possibly, yes?  TBH I was thinking of a comment but that does have "MSR"
>> in it so might come up in greps.  Not sure what others would prefer.
> 
> I am going to push revision v4 of the interrupt masking patchset, this revision
> involves several improvements based on feedback and further testing:
> 

Kindly ping, the new revsion is available at the link:

https://lore.kernel.org/all/20240614034433.602622-1-liaochang1@huawei.com/

-- 
BR
Liao, Chang