linux-kernel - Re: [PATCH 3/3] scsi: pm8001: Update log level when reading config table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 14 Jun 2024 07:37:20 +0200
From: Jinpu Wang <jinpu.wang@...os.com>
To: TJ Adams <tadamsjr@...gle.com>
Cc: Jack Wang <jinpu.wang@...ud.ionos.com>, 
	"James E . J . Bottomley" <James.Bottomley@...senpartnership.com>, 
	"Martin K . Petersen" <martin.petersen@...cle.com>, linux-scsi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Igor Pylypiv <ipylypiv@...gle.com>
Subject: Re: [PATCH 3/3] scsi: pm8001: Update log level when reading config table

On Fri, Jun 7, 2024 at 7:57 PM TJ Adams <tadamsjr@...gle.com> wrote:
>
> From: Terrence Adams <tadamsjr@...gle.com>
>
> Reading the main config table occurs as a part of initialization in
> pm80xx_chip_init(). Because of this it makes more sense to have it be a
> part of the INIT logging.
>
> Signed-off-by: Terrence Adams <tadamsjr@...gle.com>
Acked-by: Jack Wang <jinpu.wang@...os.com>
> ---
>  drivers/scsi/pm8001/pm80xx_hwi.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index a52ae6841939..8fe886dc5e47 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -568,13 +568,13 @@ static void read_main_config_table(struct pm8001_hba_info *pm8001_ha)
>         pm8001_ha->main_cfg_tbl.pm80xx_tbl.inc_fw_version =
>                 pm8001_mr32(address, MAIN_MPI_INACTIVE_FW_VERSION);
>
> -       pm8001_dbg(pm8001_ha, DEV,
> +       pm8001_dbg(pm8001_ha, INIT,
>                    "Main cfg table: sign:%x interface rev:%x fw_rev:%x\n",
>                    pm8001_ha->main_cfg_tbl.pm80xx_tbl.signature,
>                    pm8001_ha->main_cfg_tbl.pm80xx_tbl.interface_rev,
>                    pm8001_ha->main_cfg_tbl.pm80xx_tbl.firmware_rev);
>
> -       pm8001_dbg(pm8001_ha, DEV,
> +       pm8001_dbg(pm8001_ha, INIT,
>                    "table offset: gst:%x iq:%x oq:%x int vec:%x phy attr:%x\n",
>                    pm8001_ha->main_cfg_tbl.pm80xx_tbl.gst_offset,
>                    pm8001_ha->main_cfg_tbl.pm80xx_tbl.inbound_queue_offset,
> @@ -582,7 +582,7 @@ static void read_main_config_table(struct pm8001_hba_info *pm8001_ha)
>                    pm8001_ha->main_cfg_tbl.pm80xx_tbl.int_vec_table_offset,
>                    pm8001_ha->main_cfg_tbl.pm80xx_tbl.phy_attr_table_offset);
>
> -       pm8001_dbg(pm8001_ha, DEV,
> +       pm8001_dbg(pm8001_ha, INIT,
>                    "Main cfg table; ila rev:%x Inactive fw rev:%x\n",
>                    pm8001_ha->main_cfg_tbl.pm80xx_tbl.ila_version,
>                    pm8001_ha->main_cfg_tbl.pm80xx_tbl.inc_fw_version);
> --
> 2.45.2.505.gda0bf45e8d-goog
>